Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

riot.im/develop should use scalar-live, not scalar-staging (and integ mgrs should be selectable) #95

Closed
ara4n opened this issue Apr 18, 2019 · 4 comments
Labels

Comments

@ara4n
Copy link
Member

ara4n commented Apr 18, 2019

Currently riot-develop is hardcoded in the config to use scalar-staging. This means any widgets provisioned by riot-develop users end up on scalar’s staging platform for the rest of their lives, as the platform’s url is baked into the widget state event.

Given integs are a bit of a poweruser feature, this means a disproportionate amount of them are provisioned by powerusers on riot-develop, meaning that scalar-staging ends up being much more operationally important than we might think.

We saw this first hand when recovering from the security breach, where problems on staging had disproportionate impact.

I suggest that riot-develop is moved to use scalar-staging by default, but we change config.json to support multiple integ mgr entries. the user can then switch between them in UserSettings if they consciously want to use a different manager for testing or variety etc.

Similarly, we really need a way to tell which widgets come from which integ manager (and which integ manager web UI you are using!) - whether that’s colourscheme, beta icons or whatever, so that we can flush out all the spurious old staging widgets which have ended up being provisioned everywhere.

@rxl881 thoughts?

@ara4n ara4n added the T-Defect label Apr 18, 2019
@t3chguy
Copy link
Member

t3chguy commented Apr 18, 2019

Presumably you mean scalar-live as per issue title :

I suggest that riot-develop is moved to use scalar-staging by default, but we change config.json to support multiple integ mgr entries. the user can then switch between them in UserSettings if they consciously want to use a different manager for testing or variety etc.

@jaywink
Copy link
Member

jaywink commented Apr 18, 2019

Related: element-hq/element-web#4913

@turt2live
Copy link
Member

Also related: matrix-org/matrix-spec-proposals#1957

su-ex referenced this issue in SchildiChat/element-web Nov 25, 2022
* Make clear notifications work with threads ([\element-hq#9575](matrix-org/matrix-react-sdk#9575)). Fixes element-hq#23751.
* Change "None" to "Off" in notification options ([\element-hq#9539](matrix-org/matrix-react-sdk#9539)). Contributed by @Arnei.
* Advanced audio processing settings ([\element-hq#8759](matrix-org/matrix-react-sdk#8759)). Fixes element-hq#6278. Contributed by @MrAnno.
* Add way to create a user notice via config.json ([\element-hq#9559](matrix-org/matrix-react-sdk#9559)).
* Improve design of the rich text editor ([\element-hq#9533](matrix-org/matrix-react-sdk#9533)). Contributed by @florianduros.
* Enable user to zoom beyond image size ([\element-hq#5949](matrix-org/matrix-react-sdk#5949)). Contributed by @jaiwanth-v.
* Fix: Move "Leave Space" option to the bottom of space context menu ([\element-hq#9535](matrix-org/matrix-react-sdk#9535)). Contributed by @hanadi92.
* Make build scripts work on NixOS ([\element-hq#23740](element-hq#23740)).
* Fix integration manager `get_open_id_token` action and add E2E tests ([\element-hq#9520](matrix-org/matrix-react-sdk#9520)).
* Fix links being mangled by markdown processing ([\element-hq#9570](matrix-org/matrix-react-sdk#9570)). Fixes element-hq#23743.
* Fix: inline links selecting radio button ([\element-hq#9543](matrix-org/matrix-react-sdk#9543)). Contributed by @hanadi92.
* Fix wrong error message in registration when phone number threepid is in use. ([\element-hq#9571](matrix-org/matrix-react-sdk#9571)). Contributed by @bagvand.
* Fix missing avatar for show current profiles ([\element-hq#9563](matrix-org/matrix-react-sdk#9563)). Fixes element-hq#23733.
* Fix read receipts trickling down correctly ([\element-hq#9567](matrix-org/matrix-react-sdk#9567)). Fixes element-hq#23746.
* Resilience fix for homeserver without thread notification support ([\element-hq#9565](matrix-org/matrix-react-sdk#9565)).
* Don't switch to the home page needlessly after leaving a room ([\element-hq#9477](matrix-org/matrix-react-sdk#9477)).
* Differentiate download and decryption errors when showing images ([\element-hq#9562](matrix-org/matrix-react-sdk#9562)). Fixes element-hq#3892.
* Close context menu when a modal is opened to prevent user getting stuck ([\element-hq#9560](matrix-org/matrix-react-sdk#9560)). Fixes element-hq#15610 and element-hq#10781.
* Fix TimelineReset handling when no room associated ([\element-hq#9553](matrix-org/matrix-react-sdk#9553)).
* Always use current profile on thread events ([\#9524](matrix-org/matrix-react-sdk#9524)). Fixes element-hq#23648.
* Fix `ThreadView` tests not using thread flag ([\element-hq#9547](matrix-org/matrix-react-sdk#9547)). Contributed by @MadLittleMods.
* Handle deletion of `m.call` events ([\element-hq#9540](matrix-org/matrix-react-sdk#9540)). Fixes element-hq#23663.
* Fix incorrect notification count after leaving a room with notifications ([\element-hq#9518](matrix-org/matrix-react-sdk#9518)). Contributed by @Arnei.
@t3chguy t3chguy transferred this issue from element-hq/element-web May 12, 2023
@Half-Shot
Copy link
Member

This isn't hardcoded anymore?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants