Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notification issue on iOS13.3.1 #3017

Closed
manuroe opened this issue Mar 4, 2020 · 3 comments · Fixed by matrix-org/matrix-ios-kit#646 or #3018
Closed

Notification issue on iOS13.3.1 #3017

manuroe opened this issue Mar 4, 2020 · 3 comments · Fixed by matrix-org/matrix-ios-kit#646 or #3018
Assignees
@manuroe
Labels
A-Notifications P1 T-Defect Something isn't working: bugs, crashes, hangs and other reported problems
Milestone
Sprint 26: Cross-...

Comments

@manuroe
Copy link
Member

manuroe commented Mar 4, 2020

We have recently received a significant amount of reports about notification issues. As we have not released the app for a while (:/), we need to check if some changes are requested due to last iOS version.
We also need to dig into Sygnal logs.
@manuroe manuroe added T-Defect Something isn't working: bugs, crashes, hangs and other reported problems P1 A-Notifications labels Mar 4, 2020
@manuroe manuroe self-assigned this Mar 4, 2020
manuroe added a commit to matrix-org/matrix-ios-kit that referenced this issue Mar 4, 2020
@manuroe
Push notifications: Avoid any automatic deactivation
ec5b56c 
element-hq/element-ios#3017
@manuroe manuroe mentioned this issue Mar 4, 2020
Merged
manuroe added a commit that referenced this issue Mar 4, 2020
@manuroe
Push notifications: Avoid any automatic deactivation
e7789aa 
#3017
@manuroe manuroe mentioned this issue Mar 4, 2020
Merged
@manuroe manuroe reopened this Mar 10, 2020
@manuroe
Copy link
Member Author

manuroe commented Mar 10, 2020

Reopened because there have been 2 cases (Steve and Dave) where notifications were not delivered while the setup client side looks good.

@toshanmugaraj
Copy link
Contributor

Updates for iOS 13:

https://developer.apple.com/videos/play/wwdc2019/707/

  1. Need to reportIncomingCall to Callkit
  2. payload: apps-expiration to 0, need to be updated in Signal.

@manuroe
Copy link
Member Author

manuroe commented Mar 17, 2020

Reopened because there have been 2 cases (Steve and Dave) where notifications were not delivered while the setup client side looks good.

These cases of failure is a server issue: matrix-org/synapse#7075

@manuroe manuroe closed this as completed Mar 17, 2020
manuroe added a commit to matrix-org/matrix-ios-kit that referenced this issue Apr 1, 2020
@manuroe
Push notifications: Avoid any automatic deactivation
526ac40 
element-hq/element-ios#3017
manuroe added a commit to matrix-org/matrix-ios-kit that referenced this issue Apr 1, 2020
@manuroe
Push notifications: Avoid any automatic deactivation
925f707 
element-hq/element-ios#3017
manuroe added a commit that referenced this issue Apr 1, 2020
@manuroe
Push notifications: Avoid any automatic deactivation
4cc5a44 
#3017
@SwiftCrew SwiftCrew mentioned this issue May 7, 2020
Closed
@manuroe manuroe added phase:3 and removed phase:3 labels May 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@manuroe manuroe

Labels
A-Notifications P1 T-Defect Something isn't working: bugs, crashes, hangs and other reported problems
Projects
None yet
Milestone
Sprint 26: Cross-signing and e2e by d...
2 participants
@toshanmugaraj @manuroe