Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PushKit Pushers Still Exist #3577

Closed
ismailgulek opened this issue Aug 27, 2020 · 2 comments · Fixed by #3578
Closed

PushKit Pushers Still Exist #3577

ismailgulek opened this issue Aug 27, 2020 · 2 comments · Fixed by #3578
Assignees
Milestone

Comments

@ismailgulek
Copy link
Contributor

After Element 1.0.0, we should have removed PushKit pushers for all of the users. But in some crash logs we still see that we're getting VoIP pushes for events or badge counts like below. This causes a crash, does not matter if the app is at foreground or not.

2020-08-27 11:36:20.049 Riot[4644:2376191] [PushNotificationService] didReceiveIncomingPushWithPayload: {
    aps =     {
        badge = 0;
    };
}
2020-08-27 11:36:20.049 Riot[4644:2376191] [PushNotificationService] didReceiveIncomingPushWithPayload: application is in bg
2020-08-27 11:36:20.050 Riot[4644:2376191] [PushNotificationService] didReceiveIncomingPushWithPayload: lastCallInvite: (null)
2020-08-27 11:36:20.050 Riot[4644:2376191] [PushNotificationService] didReceiveIncomingPushWithPayload: iOS 13 and in bg, but we don't have the last callInvite event for the event (null). There is something wrong.
2020-08-27 11:36:20.050 Riot[4644:2376191] Apps receving VoIP pushes must post an incoming call (via CallKit or IncomingCallNotifications) in the same run loop as   pushRegistry:didReceiveIncomingPushWithPayload:forType:[withCompletionHandler:] without delay.
2020-08-27 11:36:20.051 Riot[4644:2376191] *** Assertion failure in -[PKPushRegistry _terminateAppIfThereAreUnhandledVoIPPushes], /Library/Caches/com.apple.xbs/Sources/PushKit/PushKit-37/PKPushRegistry.m:343
@ismailgulek ismailgulek added this to the Sprint 31 milestone Aug 27, 2020
@ismailgulek ismailgulek self-assigned this Aug 27, 2020
@ismailgulek ismailgulek linked a pull request Aug 27, 2020 that will close this issue
@manuroe manuroe reopened this Aug 31, 2020
@manuroe
Copy link
Member

manuroe commented Aug 31, 2020

The issue still exists in 1.0.7.

manuroe added a commit to matrix-org/matrix-ios-kit that referenced this issue Aug 31, 2020
element-hq/element-ios/issues/3577.

This reverts #646. Game rules have changed. We cannot use/abuse PushKit as before iOS13 SDK. We have to use APNS. So, we can safely clean PushKit pusher.
@manuroe manuroe self-assigned this Sep 2, 2020
@manuroe
Copy link
Member

manuroe commented Sep 7, 2020

Should be fixed in 1.0.9

@manuroe manuroe closed this as completed Sep 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants