Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SDK: Remove /send_relation to manage reactions #4507

Closed
manuroe opened this issue Jun 30, 2021 · 0 comments
Closed

SDK: Remove /send_relation to manage reactions #4507

manuroe opened this issue Jun 30, 2021 · 0 comments
Assignees
@stefanceriu
Labels
maintenance parity-with-web

Comments

@manuroe
Copy link
Member

manuroe commented Jun 30, 2021 •
edited
Loading

It has been never implemented. Instead, the server aggregates reactions on the /send api as stated in the MSC.

The code at https:/matrix-org/matrix-ios-sdk/blob/v0.19.3/MatrixSDK/Aggregations/MXAggregatedReactionsUpdater.m#L634 becomes the standard.
We can remove the sendRelationToEvent method and all code related to /send_relation.
@bmarty bmarty mentioned this issue Jun 30, 2021
Closed
@stefanceriu stefanceriu mentioned this issue Aug 10, 2021
Closed
3 tasks
@stefanceriu stefanceriu self-assigned this Aug 10, 2021
stefanceriu added a commit to matrix-org/matrix-ios-sdk that referenced this issue Aug 10, 2021
@stefanceriu
Fixes element-hq/element-ios/issues/4507, element-hq/element-ios/issu…
62b1fda 
…es/3884 -  Updated reactions count from bundled relationship messages. Removes unnecesary send_relation rest method.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stefanceriu stefanceriu

Labels
maintenance parity-with-web
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stefanceriu @manuroe