Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

“It is not possible to join an empty room” on suggested rooms in a space #5170

Closed
ShadowJonathan opened this issue Nov 19, 2021 · 6 comments · Fixed by #5950
Closed

“It is not possible to join an empty room” on suggested rooms in a space #5170

ShadowJonathan opened this issue Nov 19, 2021 · 6 comments · Fixed by #5950
Assignees
@gileluard
Labels
A-SDK A-Spaces Spaces, groups, communities O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Something isn't working: bugs, crashes, hangs and other reported problems Z-WTF WTF issues: High impact, Low Effort

Comments

@ShadowJonathan
Copy link
Contributor

Homeserver: jboi.nl

After trying to join a recommended room from a space, it tells me it is not possible with "it's not possible to join an empty room", while it most obviously isn't empty.

image

image

image
@ShadowJonathan
Copy link
Contributor Author

Version: v1,6,5

@pixlwave pixlwave added A-Spaces Spaces, groups, communities O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Something isn't working: bugs, crashes, hangs and other reported problems A-SDK labels Nov 22, 2021
@catwithbanana
Copy link

I am experiencing the same issue.

@nadonomy
Copy link
Contributor

nadonomy commented Dec 2, 2021

Thanks for reporting!

@gileluard is the critical thinking here straightforward (i.e. just a bug we need to fix)? Or, is it something which warrants more discussion?

@ShadowJonathan
Copy link
Contributor Author

(This just looks like an SDK bug to me.)

@pixlwave pixlwave added the Z-WTF WTF issues: High impact, Low Effort label Mar 11, 2022
@Anderas Anderas mentioned this issue Mar 24, 2022
Closed
@gileluard
Copy link
Contributor

@ShadowJonathan can you still reproduce this bug? I tried to reproduce it with my local synapse but no chance. The application obviously receives a "No known servers" error which means that the join room process failed because the server didn't find the room. This only happened to me after all users left the room. the room is then deleted by the server but, in your case, we can still see 32 members. Alternatively, this room could belong to another server and the via parameter is not set properly.

@ShadowJonathan
Copy link
Contributor Author

Probably the latter one, but on element it resolves fine via /join, and also fine via clicking the button on the space list, so there's something that iOS isn't doing properly then.

gileluard added a commit that referenced this issue Mar 30, 2022
@gileluard
“It is not possible to join an empty room” on suggested rooms in a sp…
7463ef6 
…ace #5170

- Fixed
gileluard added a commit that referenced this issue Mar 30, 2022
@gileluard
“It is not possible to join an empty room” on suggested rooms in a sp…
97e578c 
…ace #5170

- Added change log
@gileluard gileluard mentioned this issue Mar 30, 2022
Merged
gileluard added a commit that referenced this issue Mar 30, 2022
@gileluard
“It is not possible to join an empty room” on suggested rooms in a sp…
40ec519 
…ace #5170

- Update after review
gileluard added a commit that referenced this issue Mar 30, 2022
@gileluard
Not possible to join an empty room on some suggested rooms (#5950)
de29864 
* “It is not possible to join an empty room” on suggested rooms in a space #5170

- Fixed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gileluard gileluard

Labels
A-SDK A-Spaces Spaces, groups, communities O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Something isn't working: bugs, crashes, hangs and other reported problems Z-WTF WTF issues: High impact, Low Effort
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Not possible to join an empty room on some suggested rooms element-hq/element-ios
5 participants
@nadonomy @pixlwave @gileluard @ShadowJonathan @catwithbanana