-
Notifications
You must be signed in to change notification settings - Fork 493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Thread fallback replies are all red #5552
Comments
Hi, @janogarcia Please advise the correct behaviour here |
The message shouldn't be highlighted unless there's a user-defined keyword or her name is found in the text. There's nothing particular about threads that should trigger a highlight, the reply fallback should follow the same highlighting rules as regular messages. /cc @ismailgulek Out of scope but worth mentioning: We should change the mention status for something less visually alarming. |
@noantiq Does this also happen with regular, non-loremipsum text? I'm wondering if there's any matching keyword in there that's is the highlight. |
@janogarcia Yes this happens for every message. I made sure there was no keyword triggering it. |
Thanks for confirming and the extra screenshot, noantiq. 👍 @ismailgulek This seems to be a bug. Please make sure that the reply fallback for threads follows the same rule as regular replies for message highlighting. |
Steps to reproduce
Outcome
What did you expect?
Since threads are disabled, the thread reply is simply rendered as a reply.
What happened instead?
The thread reply is rendered as a reply but all of the reply text and the cited message are red. See screenshot below.
Your phone model
iPhone 8
Operating system version
iOS 15.3
Application version
Element 1.8.0
Homeserver
Synapse 1.52.0
Will you send logs?
No
The text was updated successfully, but these errors were encountered: