Added accessibility labels for issue: "Voiceover support for accessibility #1842" #1906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ility element-hq#1842" Signed-off-by: Marco Seizew <[email protected]>
manuroe
reviewed
Jun 25, 2018
| @@ -77,6 +77,15 @@ - (void)viewDidLoad | |||
| _roomsViewController = [self.viewControllers objectAtIndex:TABBAR_ROOMS_INDEX]; | |||
| _groupsViewController = [self.viewControllers objectAtIndex:TABBAR_GROUPS_INDEX]; | |||
|
|
|||
| // Set the accessibility labels for all buttons #1842 | |||
| [_settingsBarButtonItem setAccessibilityLabel:@"Settings"]; | |||
There was a problem hiding this comment.
These strings need to be internationalised using NSLocalizedStringFromTable(@"xxx", @"Vector", nil);
Default English values should be then added the en.lproj/Vector.string file.
|
Thanks @einMarco for this update. We just need to manage i18n and we are done. |
Signed-off-by: Marco Seizew <[email protected]>
|
I committed the changes, never worked with i18n strings, hope this is alright. |
manuroe
approved these changes
Jun 25, 2018
|
@manuroe this PR is merged into develop but I don't think it ever got to a release. It works in my Xcode build but not in the shipping v0.7.6. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added the accessibility labels for the buttons in Riot.