Ignore badge updates for virtual rooms. #5156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to langleyd/5155_ignore_badge_updates_from_virtual_rooms
ismailgulek
reviewed
Nov 16, 2021
|
📱 Scan the QR code below to install the build for this PR. If you can't scan the QR code you can install the build via this link: https://i.diawi.com/QyDoY2 |
ismailgulek
reviewed
Nov 16, 2021
ismailgulek
approved these changes
Nov 16, 2021
langleyd
deleted the
langleyd/5155_ignore_badge_updates_from_virtual_rooms
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5155
We clear the
content.badgefor the voip notification(leaving the badge the same) from the virtual room and we also send the read receipt so that the server value for the badge is also correct for subsequent notifications.