Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable the default analytics configurations for forks. #5688

Merged
merged 2 commits into from
Feb 24, 2022

Conversation

pixlwave
Copy link
Member

@pixlwave pixlwave commented Feb 24, 2022

Adds an AnalyticsConfiguration to contain all settings in a single object.

I've nested this inside of BuildSettings to avoid needing to add it to every target that contains BuildSettings as that seemed more sensible to me, but happy to change this if not.

Fixes #5687

Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with the request to block AnalyticsPromptCoordinator flows on the same BuildSettings.analyticsConfiguration.enabled flag.

@github-actions
Copy link

github-actions bot commented Feb 24, 2022

📱 Scan the QR code below to install the build for this PR.
🔒 This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.

QR code

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/2pTxdo

@pixlwave pixlwave merged commit 24056d1 into develop Feb 24, 2022
@pixlwave pixlwave deleted the doug/5687_disable_analytics_forks branch February 24, 2022 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PostHog should be disabled by default for forks
2 participants