Instrument metrics for iOS for the IA project #5401 #5836
Conversation
- Added last needed metrics
gileluard
requested review from
a team and
pixlwave
and removed request for
a team
|
📱 Scan the QR code below to install the build for this PR. If you can't scan the QR code you can install the build via this link: https://i.diawi.com/Ae9xZt |
| // MARK: - Constants | ||
|
|
||
| private enum Constants { | ||
| static let lastNumberOfSpaces: String = "AnalyticsSpaceTracker.lastNumberOfSpaces" |
There was a problem hiding this comment.
| static let lastNumberOfSpaces: String = "AnalyticsSpaceTracker.lastNumberOfSpaces" | |
| static let lastNumberOfSpacesKey: String = "AnalyticsSpaceTracker.lastNumberOfSpaces" |
| // Last number of spaces tracked | ||
| private var lastNumberOfSpaces: Int? { | ||
| get { | ||
| guard let value = UserDefaults.standard.value(forKey: Constants.lastNumberOfSpaces) as? NSNumber else { |
There was a problem hiding this comment.
Probably not important for now as I think the space service only runs in the main target, but it might potentially be useful to store this in RiotSettings or RiotSettings.defaults so that it is available in another target if ever needed.
For the FTUEUseCaseSelection I added a UserSessionProperties class that we can add user properties to on a per user basis (pre-planning for multi-account at some point) and it will store them together. Might be possible for you to use that if you wanted.
There was a problem hiding this comment.
Good point. My first thought was to not make growing RiotSettings too much but I forgot about targets. I'll make the update.
- updates after review
fix #5401