Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix app not leaving call when Jitsi widget is removed #5914

Merged
merged 1 commit into from
Mar 24, 2022
Merged

Fix app not leaving call when Jitsi widget is removed #5914

merged 1 commit into from
Mar 24, 2022

Conversation

aringenbach
Copy link
Contributor

Fixes #1575

@aringenbach aringenbach force-pushed the aringenbach/1575_jitsi_leave_call_on_remove_widget branch from ea27757 to 49482ef Compare March 24, 2022 13:58
@aringenbach aringenbach requested review from a team and pixlwave and removed request for a team March 24, 2022 14:21
@aringenbach
Copy link
Contributor Author

Sidenote: I tried to re-trigger checks but Github seems on vacation

pixlwave
pixlwave approved these changes Mar 24, 2022
View reviewed changes
Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@aringenbach aringenbach merged commit 4bda8da into develop Mar 24, 2022
@aringenbach aringenbach deleted the aringenbach/1575_jitsi_leave_call_on_remove_widget branch March 24, 2022 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pixlwave pixlwave pixlwave approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

if jitsi widget is removed from a room, the iOS app doesn't kick you out of the jitsi
2 participants
@aringenbach @pixlwave