Update Reactions component #6244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Reverted Riot.xcscheme
gileluard
requested review from
a team,
SBiOSoftWhare and
MaximeEvrard42
and removed request for
a team
|
📱 Scan the QR code below to install the build for this PR. If you can't scan the QR code you can install the build via this link: https://i.diawi.com/gBnGgN |
SBiOSoftWhare
approved these changes
Jun 3, 2022
Riot/Modules/Room/TimelineDecorations/Reactions/RoomReactionActionViewCell.swift
Outdated
Show resolved
Hide resolved
- Update after review
gileluard
requested review from
a team and
pixlwave
and removed request for
MaximeEvrard42 and
a team
pixlwave
approved these changes
Jun 8, 2022
|
|
||
| // MARK: Reactions | ||
|
|
||
| "room_event_action_reaction_more" = "%@ more"; |
There was a problem hiding this comment.
Just to check, strings added to Untranslated.strings will never be added to Weblate, so can't be translated by the community. Is this the intention here?
There was a problem hiding this comment.
Not at all! I thought we should put all new untranslated strings in this file. Thanks for the heads up :)
- fixed reaction misalignment on iOS15.5 - moved translatable strings to right Vector file
- updated podfile with online MatrixSDK
- Update after review
# Conflicts: # Riot/Assets/en.lproj/Untranslated.strings # Riot/Generated/UntranslatedStrings.swift
# Conflicts: # Podfile.lock
stefanceriu
pushed a commit
that referenced
this pull request
Jun 28, 2022
* Update Reactions component - Done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #5370
Expand / collapse reactions:
Press
Add reactionbutton:Long press:
