Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display the option "Share invite link" only when the room is accessible by link #6588

Merged
merged 1 commit into from
Aug 19, 2022

Conversation

phloux
Copy link
Contributor

@phloux phloux commented Aug 18, 2022

@phloux phloux requested a review from giomfo August 18, 2022 13:40
@sonarcloud
Copy link

sonarcloud bot commented Aug 18, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Member

@giomfo giomfo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I would let another dev team member approve it

@codecov-commenter
Copy link

Codecov Report

Merging #6588 (c921a76) into develop (3c4af39) will decrease coverage by 0.05%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop    #6588      +/-   ##
===========================================
- Coverage     6.28%    6.23%   -0.06%     
===========================================
  Files         1458     1458              
  Lines       153943   153947       +4     
  Branches     61880    61878       -2     
===========================================
- Hits          9672     9593      -79     
- Misses      143864   143953      +89     
+ Partials       407      401       -6     
Impacted Files Coverage Δ
...odal/ContactsPicker/RoomInviteViewController.swift 0.00% <0.00%> (ø)
...calAuthentication/LocalAuthenticationService.swift 27.27% <0.00%> (-27.28%) ⬇️
Config/CommonConfiguration.swift 85.71% <0.00%> (-5.20%) ⬇️
Riot/Managers/Call/CallPresenter.swift 1.08% <0.00%> (-5.14%) ⬇️
Riot/Modules/Application/AppDelegate.swift 50.76% <0.00%> (-4.62%) ⬇️
...rs/EncryptionKeyManager/EncryptionKeyManager.swift 35.41% <0.00%> (-4.17%) ⬇️
...ActivityIndicator/ActivityIndicatorPresenter.swift 49.42% <0.00%> (-2.30%) ⬇️
...anagers/PushNotification/PushNotificationService.m 10.41% <0.00%> (-1.05%) ⬇️
Riot/Modules/Application/LegacyAppDelegate.m 12.94% <0.00%> (-1.00%) ⬇️
Riot/Modules/MatrixKit/Models/Account/MXKAccount.m 7.11% <0.00%> (-0.42%) ⬇️
... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions
Copy link

📱 Scan the QR code below to install the build for this PR.
🔒 This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.

QR code

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/Xn4jRX

@phloux phloux requested review from a team and ismailgulek and removed request for a team August 19, 2022 08:05
Copy link
Contributor

@ismailgulek ismailgulek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ismailgulek
Copy link
Contributor

ismailgulek commented Aug 19, 2022

Please note that we need to use a resolving keyword to automatically close issues when PR merged.

@phloux
Copy link
Contributor Author

phloux commented Aug 19, 2022

Please note that we need to use a resolving keyword to automatically close issues when PR merged.

Ok, Thanks for this information :)

@phloux phloux merged commit a0a6f20 into develop Aug 19, 2022
@phloux phloux deleted the phlpro/6496-share-link-only-when-accessible branch August 19, 2022 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display the option "Share invite link" only when the room is accessible by link
4 participants