Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing source views for iPad. #6736

Merged
merged 1 commit into from
Sep 19, 2022
Merged

Conversation

pixlwave
Copy link
Member

@pixlwave pixlwave commented Sep 16, 2022

Fixes #6654 as the popovers were missing their source views.

@pixlwave pixlwave requested review from a team and stefanceriu and removed request for a team September 16, 2022 20:52
@sonarcloud
Copy link

sonarcloud bot commented Sep 16, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@github-actions
Copy link

📱 Scan the QR code below to install the build for this PR.
🔒 This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.

QR code

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/DkTQBd

@codecov
Copy link

codecov bot commented Sep 16, 2022

Codecov Report

Base: 9.96% // Head: 9.96% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (1025e4d) compared to base (60c8be0).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #6736      +/-   ##
===========================================
- Coverage     9.96%    9.96%   -0.01%     
===========================================
  Files         1484     1484              
  Lines       150509   150510       +1     
  Branches     60753    60755       +2     
===========================================
  Hits         14995    14995              
- Misses      134960   134961       +1     
  Partials       554      554              
Impacted Files Coverage Δ
...ot/Modules/Home/AllChats/AllChatsCoordinator.swift 22.03% <0.00%> (-0.04%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@stefanceriu stefanceriu merged commit 8d02a33 into develop Sep 19, 2022
@stefanceriu stefanceriu deleted the doug/6654-fix-ipad-popovers branch September 19, 2022 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tapping Sign out or Invite to Element in the user menu crashes on iPad.
2 participants