Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Threads notification count in main timeline including un participated… #7039

Conversation

gileluard
Copy link
Contributor

resolves #7038

ezgif-2-2d0623e55a

@sonarcloud
Copy link

sonarcloud bot commented Nov 4, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented Nov 4, 2022

Codecov Report

Base: 11.77% // Head: 11.77% // No change to project coverage 👍

Coverage data is based on head (d005344) compared to base (43f2abe).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #7039   +/-   ##
========================================
  Coverage    11.77%   11.77%           
========================================
  Files         1611     1611           
  Lines       158181   158181           
  Branches     64242    64242           
========================================
  Hits         18631    18631           
  Misses      138921   138921           
  Partials       629      629           
Flag Coverage Δ
uitests 54.62% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
Riot/Modules/Room/RoomViewController.m 0.00% <0.00%> (ø)
...es/Threads/ThreadList/Views/Cell/ThreadModel.swift 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@ismailgulek ismailgulek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gileluard gileluard merged commit 7ff30ee into develop Nov 7, 2022
@gileluard gileluard deleted the gil/7038-Threads_notification_count_in_main_timeline_including_unparticipated_threads branch November 7, 2022 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Threads notification count in main timeline including unparticipated threads
2 participants