Threads: removed "unread_thread_notifications" from sync filters #7067
Conversation
…server that doesn't support MSC3773
gileluard
requested review from
a team and
Anderas
and removed request for
a team
| } | ||
| }; | ||
|
|
||
| [mxSession supportedMatrixVersions:^(MXMatrixVersions *matrixVersions) { |
There was a problem hiding this comment.
It looks to me like [self supportLazyLoadOfRoomMembers] called above is also doing mxSession supportedMatrixVersions] check so we may be doing it twice? Could thse be somehow combined to get all server capabilities at once?
Codecov ReportBase: 11.72% // Head: 11.79% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #7067 +/- ##
===========================================
+ Coverage 11.72% 11.79% +0.07%
===========================================
Files 1613 1620 +7
Lines 158529 158731 +202
Branches 64369 64546 +177
===========================================
+ Hits 18589 18724 +135
- Misses 139305 139368 +63
- Partials 635 639 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
…server that doesn't support MSC3773 - Update after review
|
Kudos, SonarCloud Quality Gate passed!
|
gileluard
deleted the
gil/7066-unread_thread_notifications_shouldn_t_be_sent_if_the_homeserver_doesn_t_support_notifications_per_threads
branch
resolves #7066