Skip to content

Commit

Permalink
Pass our VERSION to sentry plugin's release arg via env (#19474)
Browse files Browse the repository at this point in the history
Use our existing VERSION, deduced by the packaging script, as the release for sentry sourcemaps.

This will be undefined for dev builds.
  • Loading branch information
novocaine authored Oct 22, 2021
1 parent 004e8ed commit f550d63
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
2 changes: 1 addition & 1 deletion scripts/package.sh
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ else
fi

yarn clean
yarn build
VERSION=$version yarn build

# include the sample config in the tarball. Arguably this should be done by
# `yarn build`, but it's just too painful.
Expand Down
3 changes: 2 additions & 1 deletion webpack.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -532,9 +532,10 @@ module.exports = (env, argv) => {
// upload to sentry if sentry env is present
process.env.SENTRY_DSN &&
new SentryCliPlugin({
release: process.env.RELEASE,
release: process.env.VERSION,
include: "./webapp",
}),
new webpack.EnvironmentPlugin(['VERSION']),
].filter(Boolean),

output: {
Expand Down

0 comments on commit f550d63

Please sign in to comment.