Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline terms agreement in Discovery should still show change and do not use #10635

Closed
jryans opened this issue Aug 23, 2019 · 4 comments · Fixed by matrix-org/matrix-react-sdk#3348

Comments

@jryans
Copy link
Collaborator

jryans commented Aug 23, 2019

At the moment, if you have terms with an IS that you have not agreed in the Discovery section, the only presented option is to agree:

2019-08-23 at 15 18

We should also allow:

Relates to work from #10522
See also #10636

@jryans
Copy link
Collaborator Author

jryans commented Aug 23, 2019

We may also need to carefully tweak the "Do not use" behaviour here: at the moment, "Disconnect" attempts to lookup your current state with the IS to helpfully suggest unbinding first, but we can't actually call lookup when there are unagreed terms.

@turt2live
Copy link
Member

This was actually in the design and I completely forgot to add it (sorry):
image
https://app.zeplin.io/project/5c122fa790c5b4241ffa6be7/screen/5d14ffed0c469a50ec390c47

@jryans
Copy link
Collaborator Author

jryans commented Aug 23, 2019

No worries, there are many moving pieces flying about the place... 😅

@jryans
Copy link
Collaborator Author

jryans commented Aug 23, 2019

I believe this is now unblocked with the specific copy text (filed in the related #10636).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants