Searching - multiple results for the same user

[markiceman]

I'm using Synapse + mxisd with searching in LDAP (AD). Riot Desktop application version 1.4.0 and 1.4.1 (older version are OK), have issue with searching.

Example:

If I search user with substring "kbre", then i have doubled (sometimes tripled and more) results with the same user.

I see in syslog: There are two results for user from mxisd:

one LDAP search in display name and second by 3PID. But it is still the same user.

Riot 1.3.x and older display it correctly, but Riot 1.4.x display double results. It is wrong.

It is similar situation as this:

element-hq/riot-android#1984

• Platform: desktop

• OS: Windows

• Version: 1.4.1

[markiceman]

1.4.2 have the same problem.

[t3chguy]

That looks like there are legatimely two different users, given the Matrix IDs are of different length, there are no 3PIDs involved here at all.

[markiceman]

No, it is the same user with the same MXID. Only my blue lines have different length ...

[t3chguy]

Can you share the API request responses from the network tab of your browser so we can figure out where this issue lies?

[markiceman]

I don't know, how can i do it from desktop application.

[t3chguy]

Desktop app is based on electron (chromium) so control shift i will bring up dev tools

[markiceman]

{"limited":false,"results":[{"display_name":"Bréxxxá Kateřxxx","user_id":"@kbrexxxa:matrix.airbank.cz"},{"display_name":"Bréxxxá Kateřxxx 🦙","avatar_url":"mxc://matrix.airbank.cz/kpBRzDmEJXzmhLugaQjvuxxx","user_id":"@kbrexxxa:matrix.airbank.cz"}]}

[t3chguy]

So this appears to be a mxisd issue as it returns the same user twice

[markiceman]

But older Riot versions are OK. Why?

[markiceman]

I checked the same situation in older version (1.3.2) now. Riot gets the same response, but display only one result. It is correct.

[jryans]

It sounds like there may be a regression in the address picker component then...?

[t3chguy]

I mean is it doing the wrong thing? Its being given two results by the server for its query and its rendering them

[t3chguy]

If it was to ignore one of them, which would it ignore, given they are different results?

[turt2live]

They both have the same MXID, so should be concatenated. We should probably use the most detailed record.

[jryans]

I guess I am curious what changed about the behaviour and why it only showed one before. I am worried we may have been applying some clean up logic that has gone missing, or something similar.

[markiceman]

Version 1.5.0 have the same problem.

[lampholder]

We're about to take a holistic look at user listing, so hopefully we'll sweep this issue up with that.

[kittykat]

@markiceman is there any chance you could re-test and confirm if you are still experiencing this issue or whether it was resolved in the review of the search?

[markiceman]

Still the same.

Verze Riot: 1.9.8
Verze Olm: 3.2.8

[t3chguy]

This still looks to be an issue with the backend, nothing in the spec says that the client must de-duplicate these results nor how.

[markiceman]

I have users in LDAP. Software ma1sd found one record in Display Name and another record in 3PID (maybe email address). I don't know where must be deduplicate ...

[t3chguy]

I would argue the backend should de-duplicate so that all clients don't have to

[t3chguy]

Closing as not a client issue, having every client need to de-duplicate is the wrong way for this to work.