-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Design feedback on showing invite reasons #16869
Comments
Just to check somethings please:
|
Yes, that's correct, just coincidence from the test data used here. The top avatar under the "do you want join room X" heading is the room avatar.
It would look the same as above, but with different header text like we currently have for DM invites (this is unchanged by the invite reasons PR). E.g. the header says "Do you want to chat with %(user)s?" and below the room avatar, it says " wants to chat". At the moment though, there's no way to send an invite reason for a DM in Element Web, since it's currently on exposed as a slash command in the room (see below), which means the room already exists, and for a DM it means you've already invited the one other person most likely. (Other clients might have some UI to send a reason with a DM invite though.)
At the moment, in Element Web it's an advanced feature which (I believe) is only exposed via a slash command. E.g. in some room, you can type |
Please let's also consider the safety side of this, particularly the unsolicited messaging impact. |
That might need a bit of review: it was not obvious from my 6am glance |
Just to check please @turt2live, is it the UI that's not obvious, or the solution of hiding the message by default that doesn't consider the safety side enough? Thanks |
It currently looks like the invite message is the warning text - the opacity isn't clear enough. A blur or some other component would help |
I took a quick look at this today @jryans Some options here but pulled out a few to put here. Given the majority of invites wouldn't include a message, I don't personally believe there is a reason to spend much effort on this. Something that was a bit troubling in the original UI was the use of a 'speech bubble' style box. I'm not saying speech bubbles aren't good/something Element should have, it just seems like a random place to start sneaking that in and then being inconsistent with how messages look elsewhere. In some of them I've assumed we can get things like number of members, if its a private/public room. I'm not suggesting thats the scope for this, just more things we could do, one day. |
@niquewoodhouse Thanks for working on these on such short notice! 😅 I should be able to implement one of these, such as the first image with the blurred reason. The last image which reworks the overall layout of the invite acceptance is probably to large a change for the current scope, but seems like a good future direction. |
It is near-identical to the Space invite preview so it could be a quick steal |
Hmm true, but it would imply entirely changing the general appearance of room invites, which is a much larger scope than intended here. Maybe we want to do that, but let's explore that separately with a bit more breathing room. |
This adjusts the display of invite reasons to match design feedback. Fixes element-hq/element-web#16869
This adjusts the display of invite reasons to match design feedback. Fixes element-hq/element-web#16869
Let's use this to track design feedback on matrix-org/matrix-react-sdk#5694 (which I accidentally merged early).
Context from the PR by @robintown:
The text was updated successfully, but these errors were encountered: