Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Send voice message" not visible when timeline is too narrow #19361

Open
Tracked by #61
dkasak opened this issue Oct 12, 2021 · 8 comments
Open
Tracked by #61

"Send voice message" not visible when timeline is too narrow #19361

dkasak opened this issue Oct 12, 2021 · 8 comments
Labels
A-Composer A-Threads A-Voice-Messages O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Needs-Design Z-Labs

Comments

@dkasak
Copy link
Member

dkasak commented Oct 12, 2021

Steps to reproduce

Make the window sufficiently narrow.

Outcome

What did you expect?

The "Send voice message" function should remain available.

What happened instead?

The "Send voice message" button disappears and is not added to the ... More options menu.

Operating system

Arch Linux

Browser information

Firefox 93.0

URL for webapp

app.element.io

Homeserver

matrix.org

Will you send logs?

No

@SimonBrandner SimonBrandner added A-Composer A-Voice-Messages S-Minor Impairs non-critical functionality or suitable workarounds exist O-Uncommon Most users are unlikely to come across this or unexpected workflow labels Oct 13, 2021
@dbkr dbkr added O-Occasional Affects or can be seen by some users regularly or most users rarely A-Threads labels Oct 13, 2021
@dbkr
Copy link
Member

dbkr commented Oct 13, 2021

Labelling A-Threads too because making the window really narrow probably isn't that common but when the composer's in the thread sidebar this will be very common, which will effectively mean you can't send voice messages in a thread.

@dbkr dbkr added the good first issue Good for newcomers label Oct 13, 2021
@germain-gg
Copy link
Contributor

This was discussed when we originally decided to hide it #18533 (comment)

It's non trivial to implement. Removing the good first issue label

@germain-gg germain-gg removed the good first issue Good for newcomers label Oct 13, 2021
@dkasak
Copy link
Member Author

dkasak commented Oct 13, 2021

Labelling A-Threads too because making the window really narrow probably isn't that common but when the composer's in the thread sidebar this will be very common, which will effectively mean you can't send voice messages in a thread.

Probably not too common among average users, but not that far fetched either. I triggered this while having two windows tiled side-by-side in equal proportions with both sidebars (spaces and room member list) expanded.

@dud1337
Copy link

dud1337 commented Apr 21, 2022

not that far fetched either

Can confirm.

Why is this hard to implement compared to the regular chat box's ... options?

@t3chguy
Copy link
Member

t3chguy commented Apr 21, 2022

The voice message UI itself is in the composer, unlike all the other options. That UI doesn't handle narrow rendering very well at all. All the other options are modal etc

@jakewb-b jakewb-b added O-Occasional Affects or can be seen by some users regularly or most users rarely and removed O-Uncommon Most users are unlikely to come across this or unexpected workflow labels Aug 4, 2022
@jakewb-b
Copy link

jakewb-b commented Aug 4, 2022

I'm bumping this to Occasional, and once Threads leaves beta I'd argue for it being frequent. For me, with Element maximised on a Macbook Pro 13inch, simply having the threads or room information panel expanded is enough to make the voice message option disappear from the overflow menu. I don't think that's an uncommon scenario.

@nadonomy
Copy link
Contributor

Given the threads and composer implementations are ever evolving, and we've identified changes are quite involved— we'll struggle to get ahead on the design thinking on this.

If this elevates to the top of a team or individuals list, please bump and we can figure out the right path from there.

@dkasak
Copy link
Member Author

dkasak commented Aug 10, 2022

From a design perspective, one obvious option to fix this could be to stack the voice message UI on top of the message input box when the window is too narrow to fit them side-by-side. Not sure if that's tricky to do codewise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Composer A-Threads A-Voice-Messages O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Needs-Design Z-Labs
Projects
None yet
Development

No branches or pull requests

10 participants