Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't view message edits #21321

Open
HarHarLinks opened this issue Mar 4, 2022 · 5 comments
Open

Can't view message edits #21321

HarHarLinks opened this issue Mar 4, 2022 · 5 comments
Labels
A-Message-Editing O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Z-t3chguy

Comments

@HarHarLinks
Copy link

Steps to reproduce

  1. click on the (edited) text after an edited message

Outcome

What did you expect?

show edit diff

What happened instead?

edited.mp4

The message in the video is publicly accessible in the TWIM room: https://matrix.to/#/!QQpfJfZvqxbCfeDgCj:matrix.org/$5RqkiA_deYhICPh4CJ95E48kMWeHcQSMd4RcYreH-XY?via=matrix.org&via=kde.org&via=envs.net

Operating system

arch

Application version

Element Nightly version: 2022030401 Olm version: 3.2.8

How did you install the app?

aur

Homeserver

1.53

Will you send logs?

No

@HarHarLinks
Copy link
Author

Something weird happens when you repro this, then open settings and try to click outside of the settings modal to close it. Noticed when I copied the app version from settings.

@MTRNord
Copy link
Contributor

MTRNord commented Mar 4, 2022

image

Error log I am seeing on develop for this

@HarHarLinks
Copy link
Author

HarHarLinks commented Mar 4, 2022

This might actually be 2 issues:

  1. element should not fail and just close the modal, but instead at least say how/why it fails
  2. the message may or may not be to spec, as the author says

I did one edit in Fluffychat, one in Element-desktop and one in Element-android, I think. Testing, I call it. :-)


I should note that I can view the diffs of other edited messages

@robintown robintown added A-Message-Editing O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Major Severely degrades major functionality or product features, with no satisfactory workaround labels Mar 4, 2022
@julianfoad
Copy link

All I can add is, it gets pretty tedious to see markdown rendered differently on different platforms, and then for various editors to mangle it when round-trip editing a message. Rather than hunting down specific edge cases, which could be an endless rabbit-hole, I would prefer this class of bugs to be addressed by any moves possible toward standardising markdown across platforms, even if that means choosing a markdown flavour that is better standardized over one that includes a cool feature.

@robintown
Copy link
Member

@julianfoad That would be a different issue (element-hq/element-meta#1493 perhaps), as this one is just about the edit history dialog crashing.

@t3chguy t3chguy self-assigned this Mar 10, 2022
@t3chguy t3chguy removed their assignment Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Message-Editing O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Z-t3chguy
Projects
None yet
Development

No branches or pull requests

7 participants