-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gitter sunsetting: Pass feature flag through to everywhere we use getVisibleRooms and getRoomUpgradeHistory #24417
Closed
14 tasks done
Tracked by
#24262
Labels
A-Room-Upgrades
O-Occasional
Affects or can be seen by some users regularly or most users rarely
S-Minor
Impairs non-critical functionality or suitable workarounds exist
T-Defect
Z-Gitter
Issues relating to or coming out of the Gitter migration, feature parity, etc
Comments
andybalaam
changed the title
Pass feature flag through to everywhere we use getVisibleRooms
Gitter sunsetting: Pass feature flag through to everywhere we use getVisibleRooms
Feb 2, 2023
robintown
added
T-Defect
A-Room-Upgrades
S-Minor
Impairs non-critical functionality or suitable workarounds exist
O-Occasional
Affects or can be seen by some users regularly or most users rarely
labels
Feb 2, 2023
andybalaam
changed the title
Gitter sunsetting: Pass feature flag through to everywhere we use getVisibleRooms
Gitter sunsetting: Pass feature flag through to everywhere we use getVisibleRooms and getRoomUpgradeHistory
Feb 3, 2023
Closed
4 tasks
At first glance, none of the above except the 2 already-completed items (RoomListStore.ts and SpotlightDialog.tsx) look crucial for Gitter sunsetting to go ahead. |
MadLittleMods
added
the
Z-Gitter
Issues relating to or coming out of the Gitter migration, feature parity, etc
label
Feb 14, 2023
This was referenced Mar 6, 2023
Merged
Merged
Done. Element-Web should now treat room predecessors consistently everywhere: either using MSC3946 if the labs flag is on, or not if not. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-Room-Upgrades
O-Occasional
Affects or can be seen by some users regularly or most users rarely
S-Minor
Impairs non-critical functionality or suitable workarounds exist
T-Defect
Z-Gitter
Issues relating to or coming out of the Gitter migration, feature parity, etc
Towards MSC3946
Pass the MSC3946 feature flag in wherever we call
getVisibleRooms
andgetRoomUpgradeHistory
.There may be a unified way we should approach this, but the code locations that call one or both of these functions are here:
The text was updated successfully, but these errors were encountered: