Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent save mechanism for settings #3567

Closed
lampholder opened this issue Apr 4, 2017 · 3 comments
Closed

Inconsistent save mechanism for settings #3567

lampholder opened this issue Apr 4, 2017 · 3 comments
Labels
P2 S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect

Comments

@lampholder
Copy link
Member

To persist changes on the user settings panel, I click 'X'

If I click 'X' on the room setting panel, I close it without saving my changes.

@lampholder lampholder added T-Defect design S-Minor Impairs non-critical functionality or suitable workarounds exist P2 labels Apr 6, 2017
@mittalswastik
Copy link

@lampholder Instead could we not have a prompt to save settings incase any changes have been made and yet closing it without saving. It would also be a pretty standard way.

@ara4n
Copy link
Member

ara4n commented Sep 21, 2018

this is basically a dup of #5476, or at least the 'direct manipulation' v. 'deferred manipulation' bit of the discussion.

@turt2live
Copy link
Member

Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect
Projects
None yet
Development

No branches or pull requests

4 participants