Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

device list update is *still* racy #3796

Closed
richvdh opened this issue May 3, 2017 · 0 comments
Closed

device list update is *still* racy #3796

richvdh opened this issue May 3, 2017 · 0 comments
Labels
A-E2EE P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround

Comments

@richvdh
Copy link
Member

richvdh commented May 3, 2017 •
edited
Loading

The intention was that we don't set the status to DOWNLOAD_IN_PROGRESS until the request is started, but then we moved the queueing logic to a different layer, which messed that up
@richvdh richvdh mentioned this issue May 3, 2017
Closed
25 tasks
@ara4n ara4n added A-E2EE S-Major Severely degrades major functionality or product features, with no satisfactory workaround P1 labels May 4, 2017
richvdh added a commit to matrix-org/matrix-js-sdk that referenced this issue May 5, 2017
@richvdh
Fix race in device list updates
655be2f 
Don't consider device lists up-to-date when we have another request for the
relevant user in the queue.

Fixes element-hq/element-web#3796.
@richvdh richvdh mentioned this issue May 5, 2017
Merged
@richvdh richvdh closed this as completed May 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-E2EE P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ara4n @richvdh