Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RTE: set contentEditable to false on img tags in the composer #4651

Closed
lukebarnard1 opened this issue Jul 20, 2017 · 2 comments
Closed

RTE: set contentEditable to false on img tags in the composer #4651

lukebarnard1 opened this issue Jul 20, 2017 · 2 comments

Comments

@lukebarnard1
Copy link
Contributor

Otherwise some browsers let you resize them

@ara4n
Copy link
Member

ara4n commented Jul 16, 2018

i /think/ this is fixed in slate in matrix-org/matrix-react-sdk#1890, but need to check.

@ara4n
Copy link
Member

ara4n commented Oct 8, 2018

according to https://stackoverflow.com/questions/19165944/contenteditable-image-resize-in-chrome-what-is-the-best-solution, firefox does this out of the box. so, to test this, one would plonk an img tag into the RTE somehow and then see if you can resize it via gribbers or not.

However, i don't think we allow you to copy-paste images into the new RTE in RT mode yet - and i don't think it would roundtrip a MD image into a contenteditable image in the RTE currently either.

So, i strongly suspect this is completely irrelevant until we support authoring images in slate in the first place.

@ara4n ara4n closed this as completed Oct 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants