Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Completions when composing commands #4762

Closed
4 tasks
lukebarnard1 opened this issue Aug 8, 2017 · 2 comments
Closed
4 tasks

Completions when composing commands #4762

lukebarnard1 opened this issue Aug 8, 2017 · 2 comments
Labels
A-Pills A-Slash-Commands P2

Comments

@lukebarnard1
Copy link
Contributor

lukebarnard1 commented Aug 8, 2017 •
edited
Loading

  • /invite @user still doesn't work if tab-completing (likewise for /ban etc.) because:
    • You have to complete a user that is already in the room
    • The user pill contains text == the display name of the user, not the user ID, so stripping the MD before executing the command in MD mode won't help.
  • Very similar problem with /join for rooms - you get completions for rooms that are in your sync stream but that's it.

For now, we shall disallow tab-completing when entering a command (probably showing the visual bell (red flash) instead). But to do better we should consider providing other suggestions for /join and /invite etc. based on what the command is doing. For /invite, we may want to use the user directory for example. Likewise for rooms and /join.

Related issues:
@lukebarnard1 lukebarnard1 mentioned this issue Aug 8, 2017
Closed
12 tasks
@lampholder lampholder added the P1 label Aug 9, 2017
@lampholder
Copy link
Member

P2ing because commands should support tab complete but we can release without this as long as we don't have commands with pills looking like they would work but actually failing.

@lampholder lampholder added P2 and removed P1 labels Aug 9, 2017
@pafcu pafcu mentioned this issue Oct 3, 2017
Closed
ara4n added a commit to matrix-org/matrix-react-sdk that referenced this issue May 13, 2018
@ara4n
autocomplete polishing
c967ecc 
* suppress autocomplete when navigating through history
* only search for slashcommands if in the first block of the editor
* handle suffix returns from providers correctly
* fix SelectionRange typing in the providers
* fix bugs when pressing ctrl-a, typing and then tab to complete a replacement by collapsing selection to anchor when inserting a completion in the editor
* fix element-hq/element-web#4762
@ara4n ara4n mentioned this issue May 21, 2018
Merged
33 tasks
@ara4n
Copy link
Member

ara4n commented Jul 16, 2018

fixed in matrix-org/matrix-react-sdk#1890

@ara4n ara4n closed this as completed Jul 16, 2018
@jryans jryans added the A-Pills label Jun 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Pills A-Slash-Commands P2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jryans @ara4n @lampholder @lukebarnard1