-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Homogenise all mentions of Groups to Communities (including error messages) #6003
Comments
As @t3chguy says matrix-org/matrix-react-sdk#1714 fixes some instances of this but possibly not all. |
A scan of the code reveals no remaining instances of the word "group" in the text, at least where it should be "community". Any remaining ones will be error messages that we pass thru from Synapse. |
From a quick inspection:
|
We also leak the 'group' word in the riot url: http://riot.im/app/#/group/+example_community_zappa:matrix.org |
The right solution here is surely for synapse to return proper error codes for all of these different scenarios which can then be i18nized correctly on clients. It doesn't feel like a bug that at the API level and synapse impl level we systematically call them groups though, just as long as that doesn't leak to the user. |
Spaces are now in beta |
some error messages still mention Group rather than Community
The text was updated successfully, but these errors were encountered: