Images expand in the timeline, causing a pop-in effect and scrolling issues

[turt2live]

Description

This is a regression from a previous version (possibly related to the image stuff?). Whenever someone posts an image, it starts of at ~30px high then pops in to the full height after loading. This can sometimes throw off the scroll position, leaving the user at a weird place. Previously the space was reserved for the image in the timeline.

Version information

• Platform: web (in-browser)
• Browser: Chrome 65
• OS: Windows 10
• URL: riot.im/develop

[lampholder]

I thought this was fixed (with the fix itself then causing #6652). But you filed this a day ago, which suggests it's still broken :\

[turt2live]

In this case it's the opposite of #6652: images start small then expand.

[turt2live]

For scale on how annoying this is: I deployed 0.15.1 to our webserver and got 5 complaints in the first 15 minutes. Rolling back to 0.14.2 'fixes' the issue.

[lukebarnard1]

OK. Now that we've released something, let's look at this more carefully. I'm pretty sure there's a simple solution that involves no fixup height shenanigans.

[dbkr]

Is this in an e2e room?

[dbkr]

I suspect it almost certainly is, which means its #6742 which I didn't realise was a regression

[turt2live]

This is not an e2e room. I generally don't use e2e personally except in rare cases.

It's also not specific to a given room. As mentioned in riot-dev, I can try to get a recording if it helps.

[ara4n]

@turt2live can you confirm this fixed in 0.15.2 btw?

[turt2live]

Is fixed, thank you!

[ara4n]

thanks for bumping it earlier - i'd assumed it had been fixed earlier and for whatever reason we hadn't been seeing the problem.