Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 2.37.13 #24

Merged
merged 1 commit into from
Oct 4, 2024
Merged

Version 2.37.13 #24

merged 1 commit into from
Oct 4, 2024

Conversation

jmartinesp
Copy link
Member

Changes:

[2.37.13] - 2024-10-04

  • [Android] Make RichTextEditorStyle and other data classes' constructors public to match their copy methods in Kotlin 2.0. This would cause build errors on Kotlin 2.1.

@jmartinesp jmartinesp requested a review from bmarty October 4, 2024 06:45
@codecov-commenter
Copy link

codecov-commenter commented Oct 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.16%. Comparing base (ac5ecd0) to head (f9e140e).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #24   +/-   ##
=======================================
  Coverage   90.16%   90.16%           
=======================================
  Files         179      179           
  Lines       22240    22240           
  Branches      291      291           
=======================================
  Hits        20053    20053           
  Misses       2184     2184           
  Partials        3        3           
Flag Coverage Δ
uitests 84.49% <ø> (ø)
uitests-ios 84.49% <ø> (ø)
unittests 89.05% <ø> (ø)
unittests-ios 87.54% <ø> (ø)
unittests-react 88.25% <ø> (ø)
unittests-rust 89.50% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Oct 4, 2024

Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. It seems that some iOS test(s) are failing.

@jmartinesp
Copy link
Member Author

We didn't change anything related to iOS though 🫤 .

@jmartinesp
Copy link
Member Author

Flaky tests 🎉

@jmartinesp jmartinesp merged commit c78c452 into main Oct 4, 2024
10 checks passed
@jmartinesp jmartinesp deleted the version-2.37.13 branch October 4, 2024 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants