Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sliding sync: handle room subscriptions changing required_state. #17698

Closed
erikjohnston opened this issue Sep 11, 2024 · 0 comments · Fixed by #17785
Closed

Sliding sync: handle room subscriptions changing required_state. #17698

erikjohnston opened this issue Sep 11, 2024 · 0 comments · Fixed by #17785
Labels

Comments

@erikjohnston
Copy link
Member

erikjohnston commented Sep 11, 2024

Synapse doesn't currently take into account changes to required_state in room config like it does for the timeline_limit. We should track the previous required_state and if it expands we should send down the current state for the new keys.

Motivating example is so that for room subscriptions the app can ask for more state, like room topic etc, without having to get it for all rooms.

This currently breaks things like topics and pinned events in EXI.

c.f.

# TODO: Check for changes in `required_state``

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant