MSC4140: don't cancel delayed state on own state #17810
Open
+129
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a user sends a state event, do not cancel their own delayed events for the same piece of state.
|
Depends on matrix-org/complement#742 for Complement tests to pass. |
1 task
anoadragon453
requested changes
Oct 14, 2024
| @@ -0,0 +1 @@ | |||
| When a user sends a state event, do not cancel their own delayed events (as per MSC4140) for the same piece of state. | |||
There was a problem hiding this comment.
Typically with Synapse changelog entries, we try to start with an action as the first word. Something like:
Suggested change
| When a user sends a state event, do not cancel their own delayed events (as per MSC4140) for the same piece of state. | |
| Update MSC4140 implementation to no longer cancel a user's own delayed events when they send a state event; where the state type and key match that of a scheduled delayed event. |
Comment on lines
+188
to
+194
| if delta.event_id is None: | ||
| logger.debug( | ||
| "Not handling delta for deleted state: %r %r", | ||
| delta.event_type, | ||
| delta.state_key, | ||
| ) | ||
| continue |
There was a problem hiding this comment.
Out of interest, would it be worth instead adding an argument to get_partial_current_state_deltas to filter out state deltas that do not have an associated event ID?
| @@ -424,6 +424,7 @@ async def cancel_delayed_state_events( | |||
| room_id: str, | |||
| event_type: str, | |||
| state_key: str, | |||
| not_from_localpart: str, | |||
| ) -> Optional[Timestamp]: | |||
| """ | |||
| Cancels all matching delayed state events, i.e. remove them as long as they haven't been processed. | |||
There was a problem hiding this comment.
Could you add the arguments to the docstring of this function please?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a user sends a state event, do not cancel their own delayed events for the same piece of state.
For context, see the relevant section in the MSC.
Pull Request Checklist
EventStoretoEventWorkerStore.".code blocks.(run the linters)