Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add API for fetching all persisted compiler diagnostics #13907

Merged
merged 3 commits into from
Oct 16, 2024
Merged

Add API for fetching all persisted compiler diagnostics #13907

merged 3 commits into from
Oct 16, 2024

Conversation

jonatanklosko
Copy link
Member

Adds Mix.Task.Compiler.diagnostics() that fetches all warning diagnostics persisted by each compiler in its manifest.

josevalim
josevalim reviewed Oct 16, 2024
View reviewed changes
Copy link
Member

@josevalim josevalim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic! I think we only need a test for Mix.Task.Compiler.diagnostics and we are good to go. We can probably just add a few lines to one test in compile.elixir and compile.erlang that makes sure it is included there too.

@jonatanklosko
Copy link
Member Author

@josevalim done!

@josevalim josevalim merged commit 9c42348 into elixir-lang:main Oct 16, 2024
9 checks passed
@josevalim
Copy link
Member

💚 💙 💜 💛 ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josevalim josevalim josevalim left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonatanklosko @josevalim