Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix edge case in normalizer for keyword args #13924

Merged
merged 7 commits into from
Oct 22, 2024
Merged

Fix edge case in normalizer for keyword args #13924

merged 7 commits into from
Oct 22, 2024

Conversation

josevalim
Copy link
Member

Closes #13895.
Closes #13916.

@josevalim
Copy link
Member Author

CI is failing for other reasons. Please merge if you are happy @sabiwara!

Copy link
Contributor

@sabiwara sabiwara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @josevalim 💜
LGTM, just one question

@josevalim josevalim merged commit 09d4356 into main Oct 22, 2024
18 checks passed
@josevalim josevalim deleted the normalizer-kw branch October 22, 2024 14:56
@josevalim
Copy link
Member Author

💚 💙 💜 💛 ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Crash in Macro.to_string
2 participants