Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sidebar missing until mermaidjs finishes loading #1941

Open
vlad-ngn opened this issue Aug 13, 2024 · 4 comments
Open

Sidebar missing until mermaidjs finishes loading #1941

vlad-ngn opened this issue Aug 13, 2024 · 4 comments

Comments

@vlad-ngn
Copy link

Hi!

Previous discussion: erlang/erlang-org#150

Screenshot 1:
Sidebar missing, mermaidjs loading

Screenshot from 2024-08-12 18-28-14

Screenshot 2:
Sidebar appeared after mermaidjs loaded

Screenshot from 2024-08-12 18-28-45

This is a problem for me, because mermaidjs takes ~ 1 minute to load.

Browser:
Google Chrome
Version 126.0.6478.126 (Official Build) (64-bit)

@Benjamin-Philip

@voughtdq
Copy link
Contributor

Not a browser expert, but I think the problem here might be that because html.js is loaded async, but mermaid isn't, the sidebar loads after mermaid.

Maybe changing the mermaid script to async will fix it 🤔

@voughtdq
Copy link
Contributor

Actually, ExDoc is also the wrong place to submit this issue too. I'm researching how to fix the problem, but the Mermaid scripts are installed here: https:/erlang/otp/blob/OTP-27.0.1/make/ex_doc.exs#L190

@josevalim
Copy link
Member

Thank you @voughtdq! Can you also please send a PR updating the examples here? https:/elixir-lang/ex_doc?tab=readme-ov-file#extensions

@Benjamin-Philip
Copy link
Contributor

Benjamin-Philip commented Aug 13, 2024

I'll patch the Erlang docs. Thanks @voughtdq.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

4 participants