Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Textarea: readEditor(): call callback after editing #8

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

plepe
Copy link

@plepe plepe commented Jul 18, 2018

I noticed, that the readEditor() callback on the Textarea widget won't be called after closing the external editor. This little change fixes this problem.

@iurimatias iurimatias self-assigned this Jul 19, 2018
Copy link

@GottZ GottZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

after looking at the whole file i suggest adding a return statement in front of that callback call. return callback(null, value);

@plepe
Copy link
Author

plepe commented Feb 1, 2019

Does not really change anything, but yes - why not. I modified the commit and force-pushed the change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants