Add STM32H5 flash driver #3305
Open
Add STM32H5 flash driver #3305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Luctins
commented
Sep 3, 2024
|
|
||
| pac::FLASH.nscr().write(|w| { | ||
| w.set_pg(true); | ||
| // w.set_psize(2); // 32 bits at once |
There was a problem hiding this comment.
check if size can/has to be adjusted
| clear_all_err(); | ||
|
|
||
| pac::FLASH.nscr().modify(|r| { | ||
| // TODO: later check bank swap |
There was a problem hiding this comment.
is it relevant to implement the flash bank swapping logic?
|
|
||
| pac::FLASH.nscr().modify(|r| { | ||
| // TODO: later check bank swap | ||
| r.set_bksel(match sector.bank { |
There was a problem hiding this comment.
is there a better way to map this? like some implicit conversion. if the bank swap logic is used this has to be inverted too.
| // pac::FLASH.wrp2r_cur().read().wrpsg() | ||
| // TODO: write protection check | ||
| if pac::FLASH.nscr().read().lock() == true { | ||
| error!("flash locked"); |
There was a problem hiding this comment.
return error here as we cannot write when the flash is locked.
|
@Dirbaio as far as I've tested, this works. Could you review this? Feel free to point out anything that could/should be fixed. |
|
Can anyone review this? |
|
Can you make CI green? I'll review then. |
|
Of course. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was based on the stm32h7 driver minus the flash bank logic and the fact that the h5 has secure and non secure flash.
The current implementation works, but may have some outstanding issues, like the secure registers and register lockouts, so it needs a bit more testing to be considered "ready".
I've implemented this so I could do DFU on the stm32h5, and for that it works.
Any review is very much appreciated.