Remove ember-qunit-notifications and import qunit-notifications from NPM #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| "broccoli-merge-trees": "^1.1.0", | ||
| "ember-cli-babel": "^5.1.5", | ||
| "ember-cli-version-checker": "^1.1.4", | ||
| "ember-qunit": "^0.4.18", | ||
| "qunit-notifications": "^0.1.0", |
There was a problem hiding this comment.
I just released 0.1.1 with the bower install removed
There was a problem hiding this comment.
@bcardarella thanks!
|
Published as v2.0.3. @trentmwillis - Can you update ember-cli's app/addon blueprints to match these changes? |
|
@rwjblue what updates would be needed? |
|
Ah okay, can do, didn't look for that since it was part of the blueprint for this addon as well. |
This was referenced Jul 20, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Death to Bower!
This should be totally backwards compatible. Though, do we want to throw an error/give a warning after upgrading if folks still have
ember-qunit-notificationsin theirbower.jsonas it is no longer used?Should also wait to merge for a release ofqunit-notificationswith this fix in it.cc @stefanpenner @bcardarella