Do not execute paths in node_modules for bower install. #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using the `scripts` section of your `package.json` by default it adds all binaries that are in your deps and devDeps to your path. This means that `bower` is available without having to specify `node_modules/foo/bar/bin/bar`. Also, if npm can dedupe the requirements it will. This means that the `bower` that we are supposed to use may *not* be in this projects node_modules folder.
Closed
|
@jakecraige - Would you please review and release a new version when you have confirmed? |
|
You are just reverting commit #728dc5. I dont think this is what the fix should look like. |
|
@tschakkkiiiii If i'm not mistaken, the difference between that commit and now is that right before that bower was added as a runtime dependency, when before it was not. I uninstalled the global bower and ran this and it works as expected. |
jakecraige
added a commit
that referenced
this pull request
Aug 22, 2014
Do not execute paths in node_modules for bower install.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the
scriptssection of yourpackage.jsonby default it adds all binaries that are in your deps and devDeps to your path. This means thatboweris available without having to specifynode_modules/foo/bar/bin/bar.Also, if npm can dedupe the requirements it will. This means that the
bowerthat we are supposed to use may not be in this projects node_modules folder.