Fix issues with 1.2.0+ and [email protected].{1,2}. #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[email protected].{1,2} had a bug that caused all legacy test files to be appended in the wrong order. This meant when 1.2.0 was released of ember-cli-qunit things completely broke (because QUnit was expected before it was included in the file). The underlying issue was fixed upstream and released in [email protected] (in ember-cli/ember-cli#5274). This PR adds support for pulling qunit from `bower.json` on ember-cli's < 2.2.0-beta.3 and uses NPM on ember-cli's >= 2.2.0-beta.3.
rwjblue
added a commit
that referenced
this pull request
Jan 18, 2016
Fix issues with 1.2.0+ and [email protected].{1,2}.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[email protected].{1,2} had a bug that caused all legacy test files to be appended in the wrong order. This meant when 1.2.0 was released of ember-cli-qunit things completely broke (because QUnit was expected before it was included in the file). The underlying issue was fixed upstream and released in [email protected] (in ember-cli/ember-cli#5274).
This PR adds support for pulling qunit from
bower.jsonon ember-cli's < 2.2.0-beta.3 and uses NPM on ember-cli's >= 2.2.0-beta.3.