alias-model-in-controller: allow nested properties (#80)

Fixes #79.
ember-cli · Jun 7, 2017 · 691aa24 · 691aa24
1 parent 390dc0f
commit 691aa24
Show file tree

Hide file tree

Showing 3 changed files with 73 additions and 1 deletion.
diff --git a/docs/rules/alias-model-in-controller.md b/docs/rules/alias-model-in-controller.md
@@ -19,3 +19,17 @@ export default Ember.Route.extend({
  controller.set('nail', model);
  },
 });
+```
+
+If you're passing
+[multiple models](https://guides.emberjs.com/v2.13.0/routing/specifying-a-routes-model/#toc_multiple-models) as an
+[`RSVP.hash`](https://emberjs.com/api/classes/RSVP.html#method_hash),
+you can also alias nested properties:
+
+```javascript
+const { reads } = Ember.computed;
+export default Ember.Controller.extend({
+ people: reads('model.people'),
+ pets: reads('model.pets')
+});
+```
diff --git a/lib/rules/alias-model-in-controller.js b/lib/rules/alias-model-in-controller.js
@@ -35,7 +35,10 @@ module.exports = {
  if (
  parsedCallee.length &&
  ['alias', 'readOnly', 'reads'].indexOf(parsedCallee.pop()) > -1 &&
- parsedArgs[0] === 'model'
+ (
+ parsedArgs[0] === 'model' ||
+ String(parsedArgs[0]).startsWith('model.')
+ )
  ) {
  aliasPresent = true;
  }

diff --git a/tests/lib/rules/alias-model-in-controller.js b/tests/lib/rules/alias-model-in-controller.js
@@ -12,6 +12,9 @@ const RuleTester = require('eslint').RuleTester;
 const eslintTester = new RuleTester();
 eslintTester.run('alias-model-in-controller', rule, {
  valid: [
+
+ // direct alias
+
  {
  code: 'export default Ember.Controller.extend({nail: alias("model")});',
  parserOptions: { ecmaVersion: 6, sourceType: 'module' },
@@ -61,6 +64,58 @@ eslintTester.run('alias-model-in-controller', rule, {
  code: 'export default CustomController.extend({nail: alias("model")});',
  parserOptions: { ecmaVersion: 6, sourceType: 'module' },
  },
+
+ // nested alias
+
+ {
+ code: 'export default Ember.Controller.extend({nail: alias("model.nail")});',
+ parserOptions: { ecmaVersion: 6, sourceType: 'module' },
+ },
+ {
+ code: 'export default Ember.Controller.extend({nail: computed.alias("model.nail")});',
+ parserOptions: { ecmaVersion: 6, sourceType: 'module' },
+ },
+ {
+ code: 'export default Ember.Controller.extend({nail: Ember.computed.alias("model.nail")});',
+ parserOptions: { ecmaVersion: 6, sourceType: 'module' },
+ },
+ {
+ code: 'export default Ember.Controller.extend({nail: readOnly("model.nail")});',
+ parserOptions: { ecmaVersion: 6, sourceType: 'module' },
+ },
+ {
+ code: 'export default Ember.Controller.extend({nail: computed.readOnly("model.nail")});',
+ parserOptions: { ecmaVersion: 6, sourceType: 'module' },
+ },
+ {
+ code: 'export default Ember.Controller.extend({nail: Ember.computed.readOnly("model.nail")});',
+ parserOptions: { ecmaVersion: 6, sourceType: 'module' },
+ },
+ {
+ code: 'export default Ember.Controller.extend({nail: reads("model.nail")});',
+ parserOptions: { ecmaVersion: 6, sourceType: 'module' },
+ },
+ {
+ code: 'export default Ember.Controller.extend({nail: computed.reads("model.nail")});',
+ parserOptions: { ecmaVersion: 6, sourceType: 'module' },
+ },
+ {
+ code: 'export default Ember.Controller.extend({nail: Ember.computed.reads("model.nail")});',
+ parserOptions: { ecmaVersion: 6, sourceType: 'module' },
+ },
+ {
+ code: 'export default Ember.Controller.extend(TestMixin, {nail: Ember.computed.alias("model.nail")});',
+ parserOptions: { ecmaVersion: 6, sourceType: 'module' },
+ },
+ {
+ code: 'export default Ember.Controller.extend(TestMixin, TestMixin2, {nail: Ember.computed.alias("model.nail")});',
+ parserOptions: { ecmaVersion: 6, sourceType: 'module' },
+ },
+ {
+ filename: 'example-app/controllers/path/to/some-feature.js',
+ code: 'export default CustomController.extend({nail: alias("model.nail")});',
+ parserOptions: { ecmaVersion: 6, sourceType: 'module' },
+ },
  ],
  invalid: [
  {