Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update no-empty-attrs rule #39

Merged
merged 1 commit into from
Mar 16, 2017
Merged

Update no-empty-attrs rule #39

merged 1 commit into from
Mar 16, 2017

Conversation

clcuevas
Copy link
Contributor

I am introducing this change to the no-empty-attrs rule because I have found that it makes more sense to send ESLint report errors on a per-attr property basis. This way, we can use ESLint's inline comments to disable this rule for specific attr properties rather than the entire Model.

@michalsnik
Copy link
Member

Thanks @clcuevas! This makes total sense. However could you please add some test examples regarding this change?

It's possible to check whether given error occurred on specific line:

errors: [{
  message: 'Something bad happened',
  line: 4,
}]

That would makes this PR complete and I'll be happy to merge this :)

@clcuevas
Copy link
Contributor Author

@michalsnik Thanks for the heads up on the tests! Should be good to go for another review.

add tests for changes
@michalsnik
Copy link
Member

Thanks @clcuevas! Looks great :)

@michalsnik michalsnik merged commit c6e72d4 into ember-cli:master Mar 16, 2017
@clcuevas clcuevas deleted the updateNoEmptyAttrs branch September 21, 2017 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants