Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove title #2459

Merged
merged 3 commits into from
Aug 31, 2023
Merged

remove title #2459

merged 3 commits into from
Aug 31, 2023

Conversation

patricklx
Copy link
Collaborator

@patricklx patricklx commented Aug 29, 2023

follow up of #2426
Forgot to revert this...

Description

Screenshots

Forgot to revert this...
Copy link
Member

@RobbieTheWagner RobbieTheWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look fine, but we have some test failures somehow.

@patricklx patricklx closed this Aug 31, 2023
@patricklx patricklx reopened this Aug 31, 2023
@patricklx
Copy link
Collaborator Author

strange... it's not the tooltip issue, but the highlighter offset is somehow changed now...
works okay in browser test, but not in headless...

@patricklx
Copy link
Collaborator Author

i guess showing the tooltip causes the scrollbars to appear, which then offsets the component

@RobbieTheWagner RobbieTheWagner merged commit 60de6c2 into emberjs:main Aug 31, 2023
15 checks passed
@patricklx patricklx deleted the patch-4 branch August 31, 2023 14:05
@patricklx
Copy link
Collaborator Author

@RobbieTheWagner can you remove the label? Or change it? It's not necessary for this to appear in the changelog :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants