Update to Ember 5.12 #2598
Update to Ember 5.12 #2598
Conversation
|
@patricklx could you please let me know if you notice anything wrong with this PR? I know it's huge and I don't expect you to review it line by line, but if you could please let me know what you think, that would be great, thank you! |
| @@ -924,8 +902,6 @@ module('Object Inspector', function (hooks) { | |||
| }); | |||
|
|
|||
| test('Date fields are editable', async function (assert) { | |||
There was a problem hiding this comment.
not sure why this test is failing now.
I see that we have 2 respondWith('objectInspector:saveProperty'), but we are only doing 1 save.
So I think you can just remove the first respondWith('objectInspector:saveProperty')
There was a problem hiding this comment.
@patricklx hmm, yes that does seem odd, however, the boolean tests are failing too, and that one just has one respondWith. I will try removing what you said though and see if anything changes.
| name: 'ember-lts-3.16', | ||
| npm: { | ||
| devDependencies: { | ||
| '@ember/test-helpers': '^2.4.0', |
There was a problem hiding this comment.
also need to add ember-resolver v11.0.1 until ember-source < 4.12
There was a problem hiding this comment.
@patricklx Yeah, is that safe to do? I honestly don't know if we will use consuming app's resolvers when they boot inspector? If so, that sounds like a good fix.
There was a problem hiding this comment.
@RobbieTheWagner it's safe. It's only used for the UI. We do not consume it from app code
No description provided.