-
-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved type hinting for models #462
Comments
This is actually tracked in emmett-framework/firestorm#5 Specifically regarding your suggestions, actually: User.get(1) does not return a So while binding types to fields would be easy, managing type hints on several ORM functions will be more complicated. Btw I just saw you made https:/trialandsuccess/TypeDAL, so even if I didn't check the code, I think it could be a starting point also for the Emmett ORM. |
Since according to the documentation field types are hinted to specific Python objects, it would be great to be able to type hint the result of queries as a specific model with the right types for each property.
Of course, assigning to
Field()
can't figure out the right type, but maybe doingname = Field.string()
can provide this behavior?Possibly, this could interfere with Query creation but it would be a really nice feature to have IntelliSense for database rows.
It's just a suggestion, for now I will just use my own subclass of Field:
The text was updated successfully, but these errors were encountered: