Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing unitless CSS properties #1931

Closed
wants to merge 1 commit into from
Closed

Conversation

kripod
Copy link
Contributor

@kripod kripod commented Jul 9, 2020

What: Similarly to the pull requests I made towards React and Preact, I'm adding all the missing standard and experimental unitless CSS properties, collected from MDN data.

Why: To postfix all the numeric values passed to unitless CSS properties with 'px'.

How: With thorough testing, as described in the related Preact issue.

Checklist:

  • Documentation N/A
  • Tests N/A
  • Code complete
  • Changeset

@changeset-bot
Copy link

changeset-bot bot commented Jul 9, 2020

💥 No Changeset

Latest commit: 1fdbf03

Merging this PR will not cause any packages to be released. If these changes should not cause updates to packages in this repo, this is fine 🙂

If these changes should be published to npm, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Andarist
Copy link
Member

Thank you for this! I'd like to see what happens with the React PR before we merge this here - although I don't expect any objections to this coming from the React team.

@kripod
Copy link
Contributor Author

kripod commented Jul 12, 2020

After the discussion on the React issue, I decided to close that PR, due to the reasons outlined over there. I even opened a new issue for otion, so that once we may all migrate to a more sustainable approach.

@Andarist
Copy link
Member

What do you think should happen with this PR here then?

@kripod
Copy link
Contributor Author

kripod commented Jul 13, 2020

I think this should be closed for now, until the React team decides upon a better solution.

@kripod kripod closed this Jul 13, 2020
@kripod
Copy link
Contributor Author

kripod commented Jul 20, 2020

My PR towards Preact has been accepted, so we may want to re-evaluate the value of this fix.

@kripod kripod reopened this Jul 20, 2020
@Andarist
Copy link
Member

I must say that in the end, I feel very similar as React team. Maintaining a whitelist is just troublesome - there was also no actual user request about those being missing. If that's OK with you - I would like to decline this for now.

@kripod
Copy link
Contributor Author

kripod commented Jul 30, 2020

That’s totally reasonable, thank you for answering!

@kripod kripod closed this Jul 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants