Fix: schema spec #182
Merged
Fix: schema spec #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
include/hoconsc.hrl
Outdated
| @@ -34,4 +35,8 @@ | |||
| %% Map keys are always strings, `Name' is only for documentation | |||
| -define(MAP(Name, Type), {map, Name, Type}). | |||
|
|
|||
| %% To avoid not import those function. we provide a macro to call them. | |||
| -define(MK(Type), hoconsc:mk(Type)). | |||
| -define(MK(Type, Meta), hoconsc:mk(Type, Meta)). | |||
There was a problem hiding this comment.
Should we reload all of modules rely on this header file, if it is changed and release upgrade is needed?
There was a problem hiding this comment.
I think we don't need to change this macro anymore, we only change the function implementation hoconsc:mk/2. This macro is just a shortcut to a function, too simple to be modified in the future.
The only case I can think of where it might be modified is when hoconsc:mk/2 function is renamed. But we should add new function to do that instead of changing the name.
zmstone
reviewed
Mar 18, 2022
zmstone
approved these changes
Mar 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#{roots => [{"val", hoconsc:map(key, string())}]},the
fieldsis not required.we do a lot of import actions like:
we can use macro to replace the
import.