fix(hocon_token): fix scan error message format #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zmstone
force-pushed
the
0604-fix-scan-error-unicode-display
branch
from
c1ce786
to
1e1119f
Compare
prior to this change, the scan error is formated as a utf8 binary string, this caused some unreadable error messages if the error is not formated to console using ~ts. this commit changes the error report to a map in which the line number and file paht/name is readable. this is usually enough to find the error.
zmstone
force-pushed
the
0604-fix-scan-error-unicode-display
branch
from
1e1119f
to
4d7036e
Compare
qzhuyan
approved these changes
Jun 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
prior to this change, the scan error is formated as a utf8 binary string, this caused some unreadable error messages if the error is not formated to console using ~ts.
this commit changes the error report to a map, in which, at least the line number and file paht/name are universally printable --- this is usually enough to find the error.