Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run content pack selection even if channels exist #863

Closed
dbnicholson opened this issue Oct 2, 2023 · 6 comments · Fixed by #866
Closed

Run content pack selection even if channels exist #863

dbnicholson opened this issue Oct 2, 2023 · 6 comments · Fixed by #866
Assignees
@manuq

Comments

@dbnicholson
Copy link
Member

Currently the pack selection is skipped if any channels exist under the assumption that only happens once the pack has been selected. That prevents the content from being preseeded as we're trying to do in the image builder with the result that the Discovery page is empty.
@dbnicholson dbnicholson mentioned this issue Oct 2, 2023
Closed
@manuq
Copy link
Collaborator

manuq commented Oct 3, 2023

So we should persist the pack selection somewhere. Or use the lack of download state as evidence of "pack hasn't been selected". Maybe the latter, otherwise current users will get a pack selection once again.

manuq added a commit that referenced this issue Oct 3, 2023
@manuq
Download content pack even when there is content
f21dd08 
Change the assumption for showing the welcome screens: before, when
there was content in the database it was assumed to be already
downloaded and the download was skipped. Now rely on the presence of a
DOWNLOAD_COMPLETED state persisted.

Fix #863
@manuq manuq mentioned this issue Oct 3, 2023
Merged
@manuq
Copy link
Collaborator

manuq commented Oct 3, 2023

Ready for review. This will need careful testing of all possible cases: English, Spanish, download paused/resumed by closing/reopening the app. I tried in Spanish (automatic ES pack selected) and worked fine.

manuq added a commit that referenced this issue Oct 4, 2023
@manuq
Download content pack even when there is content
a935f95 
Change the assumption for showing the welcome screens: before, when
there was content in the database it was assumed to be already
downloaded and the download was skipped. Now rely on the presence of a
DOWNLOAD_COMPLETED state persisted.

Fix #863
@manuq manuq closed this as completed in #866 Oct 4, 2023
manuq added a commit that referenced this issue Oct 5, 2023
@manuq
Download manager: Set initial state on get status
5fc604c 
Otherwise the UI will attempt a new download in the next session after
the download is complete.

Helps #863
@manuq manuq mentioned this issue Oct 5, 2023
Merged
@manuq
Copy link
Collaborator

manuq commented Oct 5, 2023

OK, I have found an issue with the previous PR when a download was attempted in a new session even after the download was completed in a previous session. Not good! This new PR should fix it: #870

This makes the get_should_resume API a bit irrelevant. But honestly I don't want to make further changes without a test suit.

@manuq manuq reopened this Oct 5, 2023
@dbnicholson
Copy link
Member Author

I merged that and it got released in 7.7.0. If there are any further issues, I think we should open a new issue.

@dbnicholson dbnicholson mentioned this issue Oct 6, 2023
Open
@dbnicholson
Copy link
Member Author

I opened #874 about using the database to persist the download state and pack selection in a more reliable way.

@vanessa-chang
Copy link

So far, no issues were found on the latest Android and Windows package for resuming the content download.

I will close this issue first.

@dbnicholson dbnicholson mentioned this issue Oct 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@manuq manuq

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Download content pack even when there is content endlessm/kolibri-explore-plugin
3 participants
@manuq @dbnicholson @vanessa-chang