-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rebase on debian 2022.1-3 #187
Commits on Jun 21, 2021
-
ci: Drop special handling of test-suite.log
The automake test harness[1] already dumps the contents of `test-suite.log` when `VERBOSE=1` is set, so we don't need to add special handling for it. 1. https://www.gnu.org/software/automake/manual/html_node/Parallel-Test-Harness.html
Configuration menu - View commit details
-
Copy full SHA for 156ec07 - Browse repository at this point
Copy the full SHA 156ec07View commit details -
ci: Update Debian and Ubuntu build dependencies
This refreshes the build dependencies installed for the GitHub Tests workflow based on the Build-Depends in the upstream packaging. The handling is now more explicit about any deviations and any release differences.
Configuration menu - View commit details
-
Copy full SHA for 410b46f - Browse repository at this point
Copy the full SHA 410b46fView commit details -
ci: Use Debian and Ubuntu release stage tags
Rather than use the release codename tags, use the release stage tags. This way the configuration (theoretically) doesn't need to be updated when new Debian and Ubuntu releases are made. For Debian stable is used instead of buster and a testing (bullseye) build is added. For Ubuntu, latest is used instead of focal for the current LTS and rolling is used instead of groovy for the latest release. This actually changes the Ubuntu build from groovy to hirsute.
Configuration menu - View commit details
-
Copy full SHA for dfe3bdc - Browse repository at this point
Copy the full SHA dfe3bdcView commit details
Commits on Jun 22, 2021
-
libtest.sh: Remove duplicate ERR trap and report_err()
Since #2377 was merged, this is in libtest-core.sh, which is sourced by libtest.sh. Signed-off-by: Simon McVittie <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 3cc4f87 - Browse repository at this point
Copy the full SHA 3cc4f87View commit details -
Configuration menu - View commit details
-
Copy full SHA for ad048c8 - Browse repository at this point
Copy the full SHA ad048c8View commit details -
Merge pull request #2384 from smcv/dedup-report-err
libtest.sh: Remove duplicate ERR trap and report_err()
Configuration menu - View commit details
-
Copy full SHA for 47b7b1e - Browse repository at this point
Copy the full SHA 47b7b1eView commit details -
lib/commit: respect SOURCE_DATE_EPOCH for commit timestamp
This tweaks `ostree_repo_write_commit` so that it checks for the envinroment variable `SOURCE_DATE_EPOCH` as a way to override the current time, which is used as the commit timestamp. Ref: https://reproducible-builds.org/docs/source-date-epoch/ Ref: https://reproducible-builds.org/specs/source-date-epoch/
Configuration menu - View commit details
-
Copy full SHA for 70a8f56 - Browse repository at this point
Copy the full SHA 70a8f56View commit details -
Merge pull request #2386 from lucab/ups/commit-timestamp-env
lib/commit: respect SOURCE_DATE_EPOCH for commit timestamp
Configuration menu - View commit details
-
Copy full SHA for e4b78a0 - Browse repository at this point
Copy the full SHA e4b78a0View commit details -
ostree-remount: Order before systemd-rfkill.*
The `systemd-rfkill.*` service falls in the category of early things that need write access to `/var`, so we need to make sure we run before or it might hit the read-only sysroot. The long-term fix for this is ostreedev/ostree#2115. Closes: coreos/fedora-coreos-tracker#746
Configuration menu - View commit details
-
Copy full SHA for 301b527 - Browse repository at this point
Copy the full SHA 301b527View commit details -
Configuration menu - View commit details
-
Copy full SHA for e00c046 - Browse repository at this point
Copy the full SHA e00c046View commit details -
Merge pull request #2387 from jlebon/pr/ostree-remount-rfkill
ostree-remount: Order before systemd-rfkill.*
Configuration menu - View commit details
-
Copy full SHA for 0900f0c - Browse repository at this point
Copy the full SHA 0900f0cView commit details
Commits on Jul 2, 2021
-
Configuration menu - View commit details
-
Copy full SHA for d6ad114 - Browse repository at this point
Copy the full SHA d6ad114View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0e58c32 - Browse repository at this point
Copy the full SHA 0e58c32View commit details
Commits on Jul 9, 2021
-
ci/release-build: evaluate package_version from m4 definition
This fixes the ci-release-build.sh script to directly source and evaluate 'package_version' from its m4 definition, without requiring a fully configured source tree.
Configuration menu - View commit details
-
Copy full SHA for d573b8d - Browse repository at this point
Copy the full SHA d573b8dView commit details
Commits on Jul 10, 2021
-
Merge pull request #2394 from lucab/ups/workflow-release
ci/release-build: evaluate package_version from m4 definition
Configuration menu - View commit details
-
Copy full SHA for a8bf003 - Browse repository at this point
Copy the full SHA a8bf003View commit details
Commits on Jul 12, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 38c14b3 - Browse repository at this point
Copy the full SHA 38c14b3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3f852d9 - Browse repository at this point
Copy the full SHA 3f852d9View commit details -
Merge pull request #2396 from ostreedev/release-2021.3
Release 2021.3
Configuration menu - View commit details
-
Copy full SHA for f216a3c - Browse repository at this point
Copy the full SHA f216a3cView commit details
Commits on Jul 14, 2021
-
man: improve statoverride description
A statoverride file written in the obvious way will produce incorrect results for two independent reasons. Document them.
Configuration menu - View commit details
-
Copy full SHA for 5b5d3b1 - Browse repository at this point
Copy the full SHA 5b5d3b1View commit details -
Merge pull request #2398 from bgilbert/statoverride
man: improve statoverride description
Configuration menu - View commit details
-
Copy full SHA for 4209525 - Browse repository at this point
Copy the full SHA 4209525View commit details
Commits on Jul 15, 2021
-
lib/repo: Factor out GPG verifier key imports
Currently the verifier only imports all the GPG keys when verifying data, but it would also be useful for inspecting the trusted keys.
Configuration menu - View commit details
-
Copy full SHA for dba2cdc - Browse repository at this point
Copy the full SHA dba2cdcView commit details -
lib/repo: Factor out GPG verifier preparation
In order to use the GPG verifier, it needs to be seeded with GPG keys after instantation. Currently this is only used for verifying data, but it will also be used for getting a list of trusted GPG keys in a subsequent commit.
Configuration menu - View commit details
-
Copy full SHA for c8715c1 - Browse repository at this point
Copy the full SHA c8715c1View commit details -
lib/repo: Allow preparing GPG verifier without global keyrings
Currently the verifier decides whether to include the global keyrings based on whether the specified remote has its own keyring or not. Allow callers to exclude the global keyrings even when that's not the case. This will be used in a subsequent commit in order to get the GPG keys only associated with a remote.
Configuration menu - View commit details
-
Copy full SHA for fc07365 - Browse repository at this point
Copy the full SHA fc07365View commit details -
lib/repo: Add ostree_repo_remote_get_gpg_keys()
This function enumerates the trusted GPG keys for a remote and returns an array of `GVariant`s describing them. This is useful to see which keys are collected by ostree for a particular remote. The same information can be gathered with `gpg`. However, since ostree allows multiple keyring locations, that's only really useful if you have knowledge of how ostree collects GPG keyrings. The format of the variants is documented in `OSTREE_GPG_KEY_GVARIANT_FORMAT`. This format is primarily a copy of selected fields within `gpgme_key_t` and its subtypes. The fields are placed within vardicts rather than using a more efficient tuple of concrete types. This will allow flexibility if more components of `gpgme_key_t` are desired in the future.
Configuration menu - View commit details
-
Copy full SHA for a50f6d0 - Browse repository at this point
Copy the full SHA a50f6d0View commit details -
bin/remote: Add list-gpg-keys subcommand
This provides a wrapper for the `ostree_repo_remote_get_gpg_keys` function to show the GPG keys associated with a remote. This is particularly useful for validating that GPG key updates have been applied. Tests are added, which checks the `ostree_repo_remote_get_gpg_keys` API by extension.
Configuration menu - View commit details
-
Copy full SHA for 74fb0c5 - Browse repository at this point
Copy the full SHA 74fb0c5View commit details -
libotutil: Import implementation of zbase32 encoding
This will be used to implement the PGP Web Key Directory (WKD) URL generation. This is a slightly cleaned up implementation[1] taken from the zbase32 author's original implementation[2]. It provides a single zbase32_encode API to convert a set of bytes to the zbase32 encoding. I believe this should be acceptable for inclusion in ostree. The license in the source files is BSD style while the original repo LICENSE file claims the Creative Commons CC0 1.0 Universal license, which is public domain. 1. https:/dbnicholson/libbase32/tree/for-ostree 2. https:/zooko/libbase32
Configuration menu - View commit details
-
Copy full SHA for fbff05e - Browse repository at this point
Copy the full SHA fbff05eView commit details -
libotutil: Add helper for GPG WKD update URLs
Calculate the advanced and direct update URLs for the key discovery portion[1] of the OpenPGP Web Key Directory specification, and include the URLs in the key listing in ostree_repo_remote_get_gpg_keys(). These URLs can be used to locate updated GPG keys for the remote. 1. https://datatracker.ietf.org/doc/html/draft-koch-openpgp-webkey-service#section-3.1
Configuration menu - View commit details
-
Copy full SHA for 4fa403a - Browse repository at this point
Copy the full SHA 4fa403aView commit details -
lib/repo: Include WKD update URLs in GPG key listing
If the key UID contains a valid email address, include the GPG WKD update URLs in GVariant returned by ostree_repo_remote_get_gpg_keys().
Configuration menu - View commit details
-
Copy full SHA for 27dc5d7 - Browse repository at this point
Copy the full SHA 27dc5d7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 90a3bda - Browse repository at this point
Copy the full SHA 90a3bdaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 30c054b - Browse repository at this point
Copy the full SHA 30c054bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 814e481 - Browse repository at this point
Copy the full SHA 814e481View commit details -
Configuration menu - View commit details
-
Copy full SHA for 81df5c8 - Browse repository at this point
Copy the full SHA 81df5c8View commit details
Commits on Jul 25, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 21615c2 - Browse repository at this point
Copy the full SHA 21615c2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5e89318 - Browse repository at this point
Copy the full SHA 5e89318View commit details -
Update upstream source from tag 'upstream/2021.3'
Update to upstream version '2021.3' with Debian dir 8860039737458a32b15fcdbfddb9cd869e19da99
Configuration menu - View commit details
-
Copy full SHA for 8b657cc - Browse repository at this point
Copy the full SHA 8b657ccView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9f49cbd - Browse repository at this point
Copy the full SHA 9f49cbdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6c73525 - Browse repository at this point
Copy the full SHA 6c73525View commit details -
Configuration menu - View commit details
-
Copy full SHA for c41ffe4 - Browse repository at this point
Copy the full SHA c41ffe4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3cfbcac - Browse repository at this point
Copy the full SHA 3cfbcacView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0e295fe - Browse repository at this point
Copy the full SHA 0e295feView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2da0bfe - Browse repository at this point
Copy the full SHA 2da0bfeView commit details -
d/test.sh, d/tests: Unset SOURCE_DATE_EPOCH
Otherwise, some tests will think we're downgrading, and fail.
Configuration menu - View commit details
-
Copy full SHA for d18bfcc - Browse repository at this point
Copy the full SHA d18bfccView commit details -
Configuration menu - View commit details
-
Copy full SHA for f3cc673 - Browse repository at this point
Copy the full SHA f3cc673View commit details
Commits on Jul 26, 2021
-
tests: Unset SOURCE_DATE_EPOCH
Some distributions set this during build in order to have reproducible builds from the same source code: for example, Debian uses the date from debian/changelog. However, some of our tests assume that `ostree commit` will result in a commit with the current date/time, and SOURCE_DATE_EPOCH breaks that assumption. Unset it for our build-time tests. Resolves: ostreedev/ostree#2405 Signed-off-by: Simon McVittie <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 2c5fa2c - Browse repository at this point
Copy the full SHA 2c5fa2cView commit details -
Merge pull request #2407 from smcv/tests-source-date-epoch
tests: Unset SOURCE_DATE_EPOCH
Configuration menu - View commit details
-
Copy full SHA for 835b114 - Browse repository at this point
Copy the full SHA 835b114View commit details
Commits on Jul 28, 2021
-
Pointer command is dangerous if there is no assignment. Log: Avoid wild pointers
Configuration menu - View commit details
-
Copy full SHA for 2817497 - Browse repository at this point
Copy the full SHA 2817497View commit details -
Merge pull request #2406 from liujianqiang-niu/main
fix: Avoid wild pointers
Configuration menu - View commit details
-
Copy full SHA for 5023278 - Browse repository at this point
Copy the full SHA 5023278View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0795289 - Browse repository at this point
Copy the full SHA 0795289View commit details -
workflows: limit permissions to reading repo contents
Move the existing docs permissions stanza to the top of the workflow for consistency.
Configuration menu - View commit details
-
Copy full SHA for d9483f8 - Browse repository at this point
Copy the full SHA d9483f8View commit details
Commits on Jul 29, 2021
-
Merge pull request #2408 from bgilbert/workflow
workflows: bump lint toolchain; restrict repository access
Configuration menu - View commit details
-
Copy full SHA for a3ce5df - Browse repository at this point
Copy the full SHA a3ce5dfView commit details
Commits on Aug 3, 2021
-
lib/sign-dummy: Handle incorrect signatures correctly
We need to check all signatures for one which passes, not just fail on the first one. Reported-by: Seth Arnold <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 75b1793 - Browse repository at this point
Copy the full SHA 75b1793View commit details -
lib/sysroot: Fix error message about creating
/var/lib
Reported-by: Seth Arnold <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 738831c - Browse repository at this point
Copy the full SHA 738831cView commit details -
ostree/dump: Fix free'ing a static string
Reported-by: Seth Arnold <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 0f95e4e - Browse repository at this point
Copy the full SHA 0f95e4eView commit details
Commits on Aug 4, 2021
-
Merge pull request #2409 from jlebon/pr/cov-fixes
A couple of Coverity fixes
Configuration menu - View commit details
-
Copy full SHA for 87db562 - Browse repository at this point
Copy the full SHA 87db562View commit details
Commits on Aug 18, 2021
-
builtins/commit: check for conflicting permissions options
This explicitly checks for commit command options asking for both non-zero UID/GID and canonical permissions at the same time, which are incompatible.
Configuration menu - View commit details
-
Copy full SHA for 5a3d5fb - Browse repository at this point
Copy the full SHA 5a3d5fbView commit details -
builtins/commit: move commit modifier to auto-cleanup
This reduces the usage of goto cleanup logic by porting the commit modifier pointer to autoptr.
Configuration menu - View commit details
-
Copy full SHA for b079c11 - Browse repository at this point
Copy the full SHA b079c11View commit details -
Merge pull request #2411 from lucab/ups/cli-commit-errors
builtins/commit: check for conflicting permissions options
Configuration menu - View commit details
-
Copy full SHA for 6cd5857 - Browse repository at this point
Copy the full SHA 6cd5857View commit details -
Merge pull request #2414 from lucab/ups/cli-commit-modifier-autoptr
builtins/commit: move commit modifier to auto-cleanup
Configuration menu - View commit details
-
Copy full SHA for cac4f21 - Browse repository at this point
Copy the full SHA cac4f21View commit details
Commits on Aug 19, 2021
-
lib/core/checksum: add flag to use canonical permissions
This adds a new `OSTREE_CHECKSUM_FLAGS_CANONICAL_PERMISSIONS` checksumming flag, which is needed in bare-user-only mode to ignore local IDs.
Configuration menu - View commit details
-
Copy full SHA for c6b72f5 - Browse repository at this point
Copy the full SHA c6b72f5View commit details -
lib/repo/checkout: use canonical perms in bare-user-only mode
This automatically enables canonical permissions for checkouts in bare-user-only mode.
Configuration menu - View commit details
-
Copy full SHA for d41fcd1 - Browse repository at this point
Copy the full SHA d41fcd1View commit details -
Merge pull request #2415 from lucab/ups/checksum-canonical-perms
lib/checkout: use canonical permissions in bare-user-only mode
Configuration menu - View commit details
-
Copy full SHA for 3209acb - Browse repository at this point
Copy the full SHA 3209acbView commit details
Commits on Aug 20, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 412e3b1 - Browse repository at this point
Copy the full SHA 412e3b1View commit details -
Revert "d/test.sh, d/tests: Unset SOURCE_DATE_EPOCH"
This reverts commit d18bfcc.
Configuration menu - View commit details
-
Copy full SHA for e7e5461 - Browse repository at this point
Copy the full SHA e7e5461View commit details -
Configuration menu - View commit details
-
Copy full SHA for 065143d - Browse repository at this point
Copy the full SHA 065143dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5518c1c - Browse repository at this point
Copy the full SHA 5518c1cView commit details -
Recent debhelper installs units into /usr/lib/systemd, so adjust our override to match either way.
Configuration menu - View commit details
-
Copy full SHA for afd405e - Browse repository at this point
Copy the full SHA afd405eView commit details -
lib/commit: autofix permissions for bare-user-only
This tweaks commit logic to detect bare-user-only repositories and canonicalize permissions automatically.
Configuration menu - View commit details
-
Copy full SHA for 8a5241d - Browse repository at this point
Copy the full SHA 8a5241dView commit details -
Merge pull request #2401 from dbnicholson/gpg-key-info
Remote GPG key info
Configuration menu - View commit details
-
Copy full SHA for 98f3fe3 - Browse repository at this point
Copy the full SHA 98f3fe3View commit details -
Merge pull request #2412 from lucab/ups/lib-commit-canonicalize
lib/commit: autofix permissions for bare-user-only
Configuration menu - View commit details
-
Copy full SHA for 2f675cf - Browse repository at this point
Copy the full SHA 2f675cfView commit details
Commits on Aug 23, 2021
-
lib/diff: ignore xattrs if disabled on either repos
This fixes the logic to detect whether xattrs should be automatically ignored when diffing.
Configuration menu - View commit details
-
Copy full SHA for 06ff77c - Browse repository at this point
Copy the full SHA 06ff77cView commit details -
Merge pull request #2417 from lucab/ups/diff-repo-ignore-xattrs
lib/diff: ignore xattrs if disabled on either repos
Configuration menu - View commit details
-
Copy full SHA for 452611e - Browse repository at this point
Copy the full SHA 452611eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6b8b4f3 - Browse repository at this point
Copy the full SHA 6b8b4f3View commit details -
bin/remote: Rename list-gpg-keys to gpg-list-keys
As pointed out in the original review, `gpg-list-keys` fits better alongside the existing `gpg-import`. Changes were done with: ``` git grep -l list-gpg-keys | xargs sed -i 's/list-gpg-keys/gpg-list-keys/' for src in $(git ls-files '*list-gpg-keys*'); do dst=${src/list-gpg-keys/gpg-list-keys} git mv "$src" "$dst" done ```
Configuration menu - View commit details
-
Copy full SHA for 58a683f - Browse repository at this point
Copy the full SHA 58a683fView commit details
Commits on Aug 24, 2021
-
Merge pull request #2419 from dbnicholson/gpg-list-keys
bin/remote: Rename list-gpg-keys to gpg-list-keys
Configuration menu - View commit details
-
Copy full SHA for 89432b2 - Browse repository at this point
Copy the full SHA 89432b2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0276f4d - Browse repository at this point
Copy the full SHA 0276f4dView commit details -
builtins/commit: set up relevant flags in bare-user-only mode
This detects bare-user-only mode and automatically enables a commit modifier with relevant flags.
Configuration menu - View commit details
-
Copy full SHA for f75552e - Browse repository at this point
Copy the full SHA f75552eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3e2360e - Browse repository at this point
Copy the full SHA 3e2360eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 00660ea - Browse repository at this point
Copy the full SHA 00660eaView commit details -
Merge pull request #2418 from lucab/ups/lib-commit-xattrs
commit: automatically skip xattrs in bare-user-only mode
Configuration menu - View commit details
-
Copy full SHA for 30909a2 - Browse repository at this point
Copy the full SHA 30909a2View commit details
Commits on Aug 25, 2021
-
lib: improve transactions auto-cleanup logic
This fixes some aspects of OstreeRepoAutoTransaction and re-aligns it with the logic in flatpak. Specifically: * link to the underlying repo through refcounting * bridge internal errors to warning messages * verify the input pointer type This is a preparation step before exposing this logic as a public API.
Configuration menu - View commit details
-
Copy full SHA for c64b4bc - Browse repository at this point
Copy the full SHA c64b4bcView commit details -
Merge pull request #2421 from lucab/ups/auto-txn-fixes
lib: improve transactions auto-cleanup logic
Configuration menu - View commit details
-
Copy full SHA for 28a0792 - Browse repository at this point
Copy the full SHA 28a0792View commit details
Commits on Aug 26, 2021
-
lib: Change read_commit_detached_metadata to be nullable
Hit this while working on some Rust code.
Configuration menu - View commit details
-
Copy full SHA for 3e30e72 - Browse repository at this point
Copy the full SHA 3e30e72View commit details -
ci: Run main GH action CI build+test as non-root
This is really the standard best practice, matching how e.g. dpkg/rpm work, as well as most local development environments (including mine) with e.g. `toolbox`.
Configuration menu - View commit details
-
Copy full SHA for fdeee16 - Browse repository at this point
Copy the full SHA fdeee16View commit details -
checkout: Save errno when re-throwing
I was seeing an `EPERM` here which was confusing. It turned out the real error was `EEXIST`. Since we're referring to the original error, but we do a lot of computation in the middle, we need to save errno.
Configuration menu - View commit details
-
Copy full SHA for 87d1157 - Browse repository at this point
Copy the full SHA 87d1157View commit details -
Merge pull request #2422 from cgwalters/allow-none-detached
lib: Change read_commit_detached_metadata to be nullable
Configuration menu - View commit details
-
Copy full SHA for 6e32084 - Browse repository at this point
Copy the full SHA 6e32084View commit details -
Merge pull request #2424 from cgwalters/test-nonroot-ci
ci: Run GH action CI build+test as non-root
Configuration menu - View commit details
-
Copy full SHA for 77a86cc - Browse repository at this point
Copy the full SHA 77a86ccView commit details -
checkout: Also ignore xattrs for union in bare-user-only mode
Followup to PRs related to ostreedev/ostree#2410 Since the test suite now covers this the test was failing on a Fedora SELinux enabled host where we see `security.selinux` even if not in the commit.
Configuration menu - View commit details
-
Copy full SHA for dd506fe - Browse repository at this point
Copy the full SHA dd506feView commit details
Commits on Aug 27, 2021
-
Merge pull request #2425 from cgwalters/hardlink-correct-errno
checkout: Save errno when re-throwing
Configuration menu - View commit details
-
Copy full SHA for 7fb0266 - Browse repository at this point
Copy the full SHA 7fb0266View commit details -
Merge pull request #2426 from cgwalters/xattrs-bareuseronly-union
checkout: Also ignore xattrs for union in bare-user-only mode
Configuration menu - View commit details
-
Copy full SHA for cfa2aec - Browse repository at this point
Copy the full SHA cfa2aecView commit details
Commits on Aug 30, 2021
-
Add an API to verify a commit signature explicitly
We have a bunch of APIs to do GPG verification of a commit, but that doesn't generalize to signapi. Further, they require the caller to check the signature status explicitly which seems like a trap. This much higher level API works with both GPG and signapi. The intention is to use this in things that are doing "external pulls" like the ostree-ext tar import support. There we will get the commitmeta from the tarball and we want to verify it at the same time we import the commit.
Configuration menu - View commit details
-
Copy full SHA for 359435d - Browse repository at this point
Copy the full SHA 359435dView commit details
Commits on Aug 31, 2021
-
Merge pull request #2340 from cgwalters/sign-verify-api
Add an API to verify a commit signature explicitly
Configuration menu - View commit details
-
Copy full SHA for 3691a23 - Browse repository at this point
Copy the full SHA 3691a23View commit details
Commits on Sep 6, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 27fcee8 - Browse repository at this point
Copy the full SHA 27fcee8View commit details -
tests/basic: Skip --no-xattrs if we have selinux
It cannot work to use `--no-xattrs` when SELinux is enabled because we get a `security.selinux` attribute on created files regardless. So just skip this test if true. Also add some `ostree fsck`s in here which helped me debug this.
Configuration menu - View commit details
-
Copy full SHA for 9f5b636 - Browse repository at this point
Copy the full SHA 9f5b636View commit details -
tests/basic: avoid changing ownership
This avoids possible issues when trying to chmod, tweaking permissions instead.
Configuration menu - View commit details
-
Copy full SHA for aa0bb17 - Browse repository at this point
Copy the full SHA aa0bb17View commit details -
tests: skip a broken fsck case
There are some existing issues around fsck in unprivileged bare mode, so this test does not really work at the moment. Leaving it as a FIXME for the moment.
Configuration menu - View commit details
-
Copy full SHA for fff2408 - Browse repository at this point
Copy the full SHA fff2408View commit details
Commits on Sep 7, 2021
-
Merge pull request #2428 from lucab/ups/tests-selinux-basic
tests: fix bare mode unprivileged 'make check'
Configuration menu - View commit details
-
Copy full SHA for 55a7e74 - Browse repository at this point
Copy the full SHA 55a7e74View commit details -
upgrade: Stabilize deployment staging
We're waaay overdue for this, it's been the default in rpm-ostree for years, and solves several important bugs around not capturing `/etc` while things are running. Also, `ostree admin upgrade --stage` (should) become idempotent. Closes: ostreedev/ostree#2389
Configuration menu - View commit details
-
Copy full SHA for 8821ec6 - Browse repository at this point
Copy the full SHA 8821ec6View commit details
Commits on Sep 8, 2021
-
repo-pull: legacy_transaction_resuming flag ignored
for deltafiles the legacy_transaction_resuming flag is not used, which will mark the commit as done, even if files are missing. using already existing commitstate_is_partial function as fix
Buddelmann, Richard RB authored and Buddelmann, Richard RB committedSep 8, 2021 Configuration menu - View commit details
-
Copy full SHA for 744bf94 - Browse repository at this point
Copy the full SHA 744bf94View commit details -
Merge pull request #2430 from cgwalters/stabilize-staging
upgrade: Stabilize deployment staging
Configuration menu - View commit details
-
Copy full SHA for 20db6e5 - Browse repository at this point
Copy the full SHA 20db6e5View commit details -
Merge pull request #2435 from RBuddel/fix-delta-files-resume-legacy-t…
…ransaction repo-pull: legacy_transaction_resuming flag ignored
Configuration menu - View commit details
-
Copy full SHA for 7e4c4f2 - Browse repository at this point
Copy the full SHA 7e4c4f2View commit details -
Add support for "custom remotes"
This will be helpful for the "ostree native container" work in https:/ostreedev/ostree-rs-ext/ Basically in order to reuse GPG/signapi verification, we need to support adding a remote, even though it can't be used via `ostree pull`. (At least, not until we merge ostree-rs-ext into ostree, but even then I think the principle stands)
Configuration menu - View commit details
-
Copy full SHA for 511c7a1 - Browse repository at this point
Copy the full SHA 511c7a1View commit details -
Merge pull request #2434 from cgwalters/custom-remote
Add support for "custom remotes"
Configuration menu - View commit details
-
Copy full SHA for ce36e05 - Browse repository at this point
Copy the full SHA ce36e05View commit details -
Configuration menu - View commit details
-
Copy full SHA for 55090f1 - Browse repository at this point
Copy the full SHA 55090f1View commit details -
Configuration menu - View commit details
-
Copy full SHA for d1a73e1 - Browse repository at this point
Copy the full SHA d1a73e1View commit details
Commits on Sep 9, 2021
-
Merge pull request #2438 from cgwalters/release-2021.4
Release 2021.4
Configuration menu - View commit details
-
Copy full SHA for 09804f7 - Browse repository at this point
Copy the full SHA 09804f7View commit details
Commits on Sep 10, 2021
-
tests/pull-test: Avoid duplicating test numbers
We do this in other places; avoids touching two numbers when adding tests. Let computers do the addition.
Configuration menu - View commit details
-
Copy full SHA for 213b860 - Browse repository at this point
Copy the full SHA 213b860View commit details -
Having to touch a global test counter when adding tests is a recipe for conflicts between PRs. The TAP protocol allows *ending* with the expected number of tests, so the best way to do this is to have an explicit API like our `tap_ok` which bumps a counter, then end with `tap_end`. I ported one test as a demo.
Configuration menu - View commit details
-
Copy full SHA for bc30806 - Browse repository at this point
Copy the full SHA bc30806View commit details
Commits on Sep 13, 2021
-
Merge pull request #2440 from cgwalters/unit-test-counting
two small unit test patches
Configuration menu - View commit details
-
Copy full SHA for e8394c7 - Browse repository at this point
Copy the full SHA e8394c7View commit details
Commits on Sep 30, 2021
-
bin/commit: Fix --tree=tar with --selinux-policy
The logic for `--selinux-policy` ended up in the `--tree=dir` path, but there's no reason for that. Fix the imported labeling with `--tree=tar`. Prep for use with containers. We had this bug because the previous logic was trying to avoid duplicating the code for generic `--selinux-policy` and the case of `--selinux-policy-from-base --tree=dir`. It's a bit more code, but it's cleaner if we dis-entangle them.
Configuration menu - View commit details
-
Copy full SHA for ab12e38 - Browse repository at this point
Copy the full SHA ab12e38View commit details -
Merge pull request #2448 from cgwalters/fix-selinux-policy
bin/commit: Fix --tree=tar with --selinux-policy
Configuration menu - View commit details
-
Copy full SHA for 4b61768 - Browse repository at this point
Copy the full SHA 4b61768View commit details -
This updates to the modern glib 0.14 and paves the way for some reverse dependency testing by using ostree-ext's code.
Configuration menu - View commit details
-
Copy full SHA for bcc0ef7 - Browse repository at this point
Copy the full SHA bcc0ef7View commit details -
There's a general Unix philosophy that "silence is golden". However, when one is explicitly invoking an error check it's nice to see explicit success. We already print various statistics, so ending with a happy note has no extra cost.
Configuration menu - View commit details
-
Copy full SHA for 1ed290c - Browse repository at this point
Copy the full SHA 1ed290cView commit details -
repo: Add an API to init
OstreeSePolicy
from commit directlyThis is part of `OstreeCommitModifier`, but I'm not using that in some of the ostree-ext Rust code. It just makes more sense as a direct policy API, where it should have been in the first place. There's already support for setting a policy object on a commit modifier, so that's all the old API needs to do now.
Configuration menu - View commit details
-
Copy full SHA for 1b9e3a9 - Browse repository at this point
Copy the full SHA 1b9e3a9View commit details -
Configuration menu - View commit details
-
Copy full SHA for ddc0d54 - Browse repository at this point
Copy the full SHA ddc0d54View commit details -
Configuration menu - View commit details
-
Copy full SHA for d61a499 - Browse repository at this point
Copy the full SHA d61a499View commit details -
Configuration menu - View commit details
-
Copy full SHA for 841902c - Browse repository at this point
Copy the full SHA 841902cView commit details -
Merge pull request #2447 from cgwalters/sepolicy-for-commit
repo: Add an API to init `OstreeSePolicy` from commit directly
Configuration menu - View commit details
-
Copy full SHA for 5bf4b1d - Browse repository at this point
Copy the full SHA 5bf4b1dView commit details
Commits on Oct 1, 2021
-
lib: Add an API to construct a
MutableTree
from a commitThis is nicer than having the caller parse the commit object, or indirect via the `OstreeRepoFile*` object of the root. Will be used in ostree-rs-ext around tar parsing.
Configuration menu - View commit details
-
Copy full SHA for 868776a - Browse repository at this point
Copy the full SHA 868776aView commit details -
deploy: Ignore sockets, fifos in /etc during merge
https://bugzilla.redhat.com/show_bug.cgi?id=1945274 is an issue where a privileged kubernetes daemonset is writing a socket into `/etc`. This makes ostree upgrades barf. Now, they should clearly move it to `/run`. However, one option is for us to just ignore it instead of erroring out. Some brief investigation shows that e.g. `git add somesocket` is a silent no-op, which is an argument in favor of ignoring it. Closes: ostreedev/ostree#2446
Configuration menu - View commit details
-
Copy full SHA for e6a560b - Browse repository at this point
Copy the full SHA e6a560bView commit details
Commits on Oct 4, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 488edf6 - Browse repository at this point
Copy the full SHA 488edf6View commit details
Commits on Oct 5, 2021
-
repo/private: allow committing/aborting through a transaction guard
This enhances the auto-transaction logic, augmenting the scope of a transaction guard. It allows committing or aborting a transaction through its guard. It also supports tracking the completion status of a transaction guard, avoiding double commits/aborts, while retaining the auto-cleanup logic.
Configuration menu - View commit details
-
Copy full SHA for c987534 - Browse repository at this point
Copy the full SHA c987534View commit details -
Merge pull request #2454 from lucab/ups/auto-txn-complete
repo/private: allow committing/aborting through a transaction guard
Configuration menu - View commit details
-
Copy full SHA for cf2eef8 - Browse repository at this point
Copy the full SHA cf2eef8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8cb5d92 - Browse repository at this point
Copy the full SHA 8cb5d92View commit details -
Configuration menu - View commit details
-
Copy full SHA for 63bf5e6 - Browse repository at this point
Copy the full SHA 63bf5e6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 085ba80 - Browse repository at this point
Copy the full SHA 085ba80View commit details -
Update upstream source from tag 'upstream/2021.4'
Update to upstream version '2021.4' with Debian dir 62caccdb763680564f5ec02ffa2178ae1fe1ac77
Configuration menu - View commit details
-
Copy full SHA for 5b4deb9 - Browse repository at this point
Copy the full SHA 5b4deb9View commit details -
Configuration menu - View commit details
-
Copy full SHA for bcb88f0 - Browse repository at this point
Copy the full SHA bcb88f0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0fb8e22 - Browse repository at this point
Copy the full SHA 0fb8e22View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4ec48c3 - Browse repository at this point
Copy the full SHA 4ec48c3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 585ee53 - Browse repository at this point
Copy the full SHA 585ee53View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5ee5d0d - Browse repository at this point
Copy the full SHA 5ee5d0dView commit details -
d/control: Canonicalize field name case Multi-arch => Multi-Arch
Changes-By: lintian-brush Fixes: lintian: cute-field See-also: https://lintian.debian.org/tags/cute-field.html
Configuration menu - View commit details
-
Copy full SHA for 9e6202c - Browse repository at this point
Copy the full SHA 9e6202cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6901466 - Browse repository at this point
Copy the full SHA 6901466View commit details -
Bump debhelper compat level from 12 to 13
- debian/rules: Drop --fail-missing argument to dh_missing, which is now the default. Changes-By: lintian-brush Fixes: lintian: package-uses-old-debhelper-compat-version See-also: https://lintian.debian.org/tags/package-uses-old-debhelper-compat-version.html
Configuration menu - View commit details
-
Copy full SHA for e8b0f6c - Browse repository at this point
Copy the full SHA e8b0f6cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 007f9e9 - Browse repository at this point
Copy the full SHA 007f9e9View commit details -
test-commit-sign.sh: Skip a unit test when running as an installed-test
Signed-off-by: Simon McVittie <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 92ed185 - Browse repository at this point
Copy the full SHA 92ed185View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9fcb954 - Browse repository at this point
Copy the full SHA 9fcb954View commit details -
Configuration menu - View commit details
-
Copy full SHA for 36d62a7 - Browse repository at this point
Copy the full SHA 36d62a7View commit details
Commits on Oct 6, 2021
-
Merge pull request #2458 from ostreedev/release-2021.5
Release 2021.5
Configuration menu - View commit details
-
Copy full SHA for ccb4a1f - Browse repository at this point
Copy the full SHA ccb4a1fView commit details -
Remove OstreeTlsCertInteraction bits from introspection
We filter out everything named `-private.h` from scanning, which differs from the gtk-doc exclude. Eventually this will be solved when we switch to the new gir-based docs. Came up in ostreedev/ostree-rs#34 (comment)
Configuration menu - View commit details
-
Copy full SHA for a73a286 - Browse repository at this point
Copy the full SHA a73a286View commit details -
Merge pull request #2459 from smcv/test-commit-sign
test-commit-sign.sh: Skip a unit test when running as an installed-test
Configuration menu - View commit details
-
Copy full SHA for 307707c - Browse repository at this point
Copy the full SHA 307707cView commit details
Commits on Oct 7, 2021
-
Configuration menu - View commit details
-
Copy full SHA for cc70ab2 - Browse repository at this point
Copy the full SHA cc70ab2View commit details -
prepare-root: tweak log messages to clarify errors
This rewords errors and log messages in the functions which take care of preparing sysroot in initramfs. Depending on the boot flow, it is possible to reach this logic with a sysroot mounted (unexpectedly) as read-only. In that case, let's clearly point out the problematic mountpoint.
Configuration menu - View commit details
-
Copy full SHA for f4be52b - Browse repository at this point
Copy the full SHA f4be52bView commit details -
Merge pull request #2461 from lucab/ups/prepare-root-logging
prepare-root: tweak log messages to clarify errors
Configuration menu - View commit details
-
Copy full SHA for f4a3837 - Browse repository at this point
Copy the full SHA f4a3837View commit details
Commits on Oct 10, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 857d272 - Browse repository at this point
Copy the full SHA 857d272View commit details -
Configuration menu - View commit details
-
Copy full SHA for f74de94 - Browse repository at this point
Copy the full SHA f74de94View commit details -
Configuration menu - View commit details
-
Copy full SHA for 75e180c - Browse repository at this point
Copy the full SHA 75e180cView commit details -
Update upstream source from tag 'upstream/2021.5'
Update to upstream version '2021.5' with Debian dir 18336141e32a1132d6f87bc481234c1a335fa76c
Configuration menu - View commit details
-
Copy full SHA for 737f00a - Browse repository at this point
Copy the full SHA 737f00aView commit details -
Configuration menu - View commit details
-
Copy full SHA for de31926 - Browse repository at this point
Copy the full SHA de31926View commit details -
Configuration menu - View commit details
-
Copy full SHA for fb8b2ec - Browse repository at this point
Copy the full SHA fb8b2ecView commit details
Commits on Oct 11, 2021
-
repo/private: move OstreeRepoAutoTransaction to a boxed type
This defines `OstreeRepoAutoTransaction` as a boxed type, in order to support auto-generating bindings for it. That first requires adding internal reference-counting to it, to allow freely copying/freeing references to a single transaction guard.
Configuration menu - View commit details
-
Copy full SHA for 8a9737a - Browse repository at this point
Copy the full SHA 8a9737aView commit details -
docs: Do not convert -- & --- to en/em-dash
'--' is frequently used for command line options and was thus incorrectly rendered as a special en-dash symbol.
Configuration menu - View commit details
-
Copy full SHA for 5af2a52 - Browse repository at this point
Copy the full SHA 5af2a52View commit details
Commits on Oct 12, 2021
-
Merge pull request #2465 from travier/docfixes
docs: Do not convert -- & --- to en/em-dash
Configuration menu - View commit details
-
Copy full SHA for 16157e7 - Browse repository at this point
Copy the full SHA 16157e7View commit details
Commits on Oct 13, 2021
-
Merge pull request #2464 from lucab/ups/box-auto-txn
repo/private: move OstreeRepoAutoTransaction to a boxed type
Configuration menu - View commit details
-
Copy full SHA for dc1411f - Browse repository at this point
Copy the full SHA dc1411fView commit details -
remote: Fix gcc
-fanalyzer
warningIn general, we're probably going to need to change most of our `g_return_if_fail` to `g_assert`. The analyzer flags that the function can return `NULL`, but the caller isn't prepared for this. In practice, let's abort.
Configuration menu - View commit details
-
Copy full SHA for a8eed03 - Browse repository at this point
Copy the full SHA a8eed03View commit details -
deployment: Fix gcc
-fanalyzer
warningIn general, we're probably going to need to change most of our `g_return_if_fail` to `g_assert`. The analyzer flags that the function can return `NULL`, but the caller isn't prepared for this. In practice, let's abort.
Configuration menu - View commit details
-
Copy full SHA for 9a7f9c2 - Browse repository at this point
Copy the full SHA 9a7f9c2View commit details -
sysroot: Fix gcc
-fanalyzer
warningIn general, we're probably going to need to change most of our `g_return_if_fail` to `g_assert`. The analyzer flags that the function can return `NULL`, but the caller isn't prepared for this. In practice, let's abort.
Configuration menu - View commit details
-
Copy full SHA for 520b45a - Browse repository at this point
Copy the full SHA 520b45aView commit details -
fetcher/soup: Fix gcc
-fanalyzer
warningIn general, we're probably going to need to change most of our `g_return_if_fail` to `g_assert`. The analyzer flags that the function can return `NULL`, but the caller isn't prepared for this. In practice, let's abort.
Configuration menu - View commit details
-
Copy full SHA for 3159e04 - Browse repository at this point
Copy the full SHA 3159e04View commit details -
static-delta: Fix probably not actually possible NULL deref
Flagged by `gcc -fanalyzer`. I didn't study this really deeply but I think it's not actually reachable. Anyways, let's catch it on general principle.
Configuration menu - View commit details
-
Copy full SHA for f355482 - Browse repository at this point
Copy the full SHA f355482View commit details -
utils: Fix unreachable
NULL
deref by adding assertionAgain this one is just in theory, but let's add an assertion.
Configuration menu - View commit details
-
Copy full SHA for 54bf42c - Browse repository at this point
Copy the full SHA 54bf42cView commit details -
variantutil: Fix gcc
-fanalyzer
warninAdd some not-NULL assertions for return values from glib, and upgrade some `g_return_if_fail` to `g_assert`.
Configuration menu - View commit details
-
Copy full SHA for 029a9d5 - Browse repository at this point
Copy the full SHA 029a9d5View commit details
Commits on Oct 14, 2021
-
Merge pull request #2463 from cgwalters/fix-fanalyzer
Fix various mostly theoretical gcc `-fanalyzer` issues
Configuration menu - View commit details
-
Copy full SHA for 6b8295a - Browse repository at this point
Copy the full SHA 6b8295aView commit details -
Attempt to update packit flow to build in COPR
No idea if this will really work, but at least `packit srpm` does work now.
Configuration menu - View commit details
-
Copy full SHA for 7ba8dbf - Browse repository at this point
Copy the full SHA 7ba8dbfView commit details -
libglnx: Bump to ef502aabf7d3a0d37f9c4d228f870ac93404447b
Various fixes there, including one for `gcc -fanalyzer`. Update submodule: libglnx
Configuration menu - View commit details
-
Copy full SHA for baa57ff - Browse repository at this point
Copy the full SHA baa57ffView commit details -
Configuration menu - View commit details
-
Copy full SHA for 09f4ad7 - Browse repository at this point
Copy the full SHA 09f4ad7View commit details
Commits on Oct 15, 2021
-
Merge pull request #2455 from cgwalters/packit
Attempt to update packit flow to build in COPR
Configuration menu - View commit details
-
Copy full SHA for ec8cf31 - Browse repository at this point
Copy the full SHA ec8cf31View commit details -
Followup to ostreedev/ostree#2463 One thing I noticed here is we lost usage of `build-check.sh` which also invokes `clang`, which doesn't speak `-fanalyzer` and would be broken by this if we try to enable `build-check.sh` again. But that can come later.
Configuration menu - View commit details
-
Copy full SHA for fda41e8 - Browse repository at this point
Copy the full SHA fda41e8View commit details
Commits on Oct 18, 2021
-
tests/rollsum: Use
g_malloc
notmalloc
To pacify gcc's `-fanalyzer`.
Configuration menu - View commit details
-
Copy full SHA for 58dc6a0 - Browse repository at this point
Copy the full SHA 58dc6a0View commit details -
Merge pull request #2466 from cgwalters/ci-fanalyzer
ci: Enable -fanalyzer
Configuration menu - View commit details
-
Copy full SHA for 5d045f3 - Browse repository at this point
Copy the full SHA 5d045f3View commit details
Commits on Oct 19, 2021
-
tests/var-mount: tweak test setup
This reworks the var-mount destructive test in order to properly use the datadir for the current stateroot instead of a duplicated one. In turn, it ensures that the resulting `var.mount` after reboot is correctly pointing to the same location which hosted `/var` on the previous boot.
Configuration menu - View commit details
-
Copy full SHA for f93d966 - Browse repository at this point
Copy the full SHA f93d966View commit details -
Merge pull request #2468 from lucab/ups/tests-var-mount
tests/var-mount: tweak test setup
Configuration menu - View commit details
-
Copy full SHA for 9692437 - Browse repository at this point
Copy the full SHA 9692437View commit details
Commits on Oct 26, 2021
-
prepare-root: make all mount operations silent
This adds a `MS_SILENT` flag to all `mount(2)` calls, reducing the amount of kernel logs produced on each boot. Those messages do not contain actionable details, and in the "mount plus read-only remount" case they can easily become highly redundant.
Configuration menu - View commit details
-
Copy full SHA for 848fe54 - Browse repository at this point
Copy the full SHA 848fe54View commit details -
Merge pull request #2471 from lucab/ups/prepare-root-silent-mounts
prepare-root: make all mount operations silent
Configuration menu - View commit details
-
Copy full SHA for 1e6077a - Browse repository at this point
Copy the full SHA 1e6077aView commit details -
prepare-root: check return codes for errors when assembling paths
This adds checks around all `snprintf` calls in order to detect failures and gracefully abort.
Configuration menu - View commit details
-
Copy full SHA for ca84da6 - Browse repository at this point
Copy the full SHA ca84da6View commit details -
prepare-root: get rid of a global variable
This moves a global mutable variable to a smaller local scope, as it is not really used outside of that.
Configuration menu - View commit details
-
Copy full SHA for 7c17daa - Browse repository at this point
Copy the full SHA 7c17daaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6e01650 - Browse repository at this point
Copy the full SHA 6e01650View commit details -
Configuration menu - View commit details
-
Copy full SHA for b7efd16 - Browse repository at this point
Copy the full SHA b7efd16View commit details
Commits on Nov 1, 2021
-
prepare-root: check for read-only sysroot status early on
This moves read-only sysroot checks upfront, so that they are not intermixed with mount operations. It has no immediate side-effects, but allow these check to be independent from the rest of the mounting logic (and future changes to it).
Configuration menu - View commit details
-
Copy full SHA for 63d0c4c - Browse repository at this point
Copy the full SHA 63d0c4cView commit details -
Merge pull request #2475 from lucab/ups/prepare-root-check-first
prepare-root: check for read-only sysroot status early on
Configuration menu - View commit details
-
Copy full SHA for 800289a - Browse repository at this point
Copy the full SHA 800289aView commit details
Commits on Nov 3, 2021
-
prepare-root: Set up sysroot readonly in initramfs
Let's ensure things are right from the start in the initramfs; this closes off various race conditions. Followup to ostreedev/ostree@3564225 Closes: ostreedev/ostree#2115
Configuration menu - View commit details
-
Copy full SHA for c553b5c - Browse repository at this point
Copy the full SHA c553b5cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 48f582b - Browse repository at this point
Copy the full SHA 48f582bView commit details -
lib: Fix a bad call to g_file_get_child
In Glib, since commit 3a6e8bc8876e149c36b6b14c6a25a718edb581ed, `g_file_get_child` does not accept absolute path as paramater anymore. The broken assertion was encountered during `ostree admin deploy` command for the checkout of subpath `etc`. Example of error log: ``` (ostree admin deploy:1640): GLib-GIO-CRITICAL **: 03:42:00.570: g_file_get_child: assertion '!g_path_is_absolute (name)' failed (ostree admin deploy:1640): GLib-GIO-CRITICAL **: 03:42:00.570: g_file_query_info: assertion 'G_IS_FILE (file)' failed ** OSTree:ERROR:src/ostree/ot-main.c:232:ostree_run: assertion failed: (success || error) Bail out! OSTree:ERROR:src/ostree/ot-main.c:232:ostree_run: assertion failed: (success || error) ```
Configuration menu - View commit details
-
Copy full SHA for adc097a - Browse repository at this point
Copy the full SHA adc097aView commit details
Commits on Nov 4, 2021
-
Merge pull request #2187 from cgwalters/sysroot-ro-initramfs
prepare-root: Set up sysroot readonly in initramfs
Configuration menu - View commit details
-
Copy full SHA for e580eca - Browse repository at this point
Copy the full SHA e580ecaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 56428d5 - Browse repository at this point
Copy the full SHA 56428d5View commit details
Commits on Nov 9, 2021
-
ci: Require
libcap2-bin
forcapsh
This was previously pulled in indirectly, but it looks like we need to require it explicitly in newer Ubuntu.
Configuration menu - View commit details
-
Copy full SHA for 3b338df - Browse repository at this point
Copy the full SHA 3b338dfView commit details -
Merge pull request #2476 from valentindavid/valentindavid/glib-fix
lib: Fix a bad call to g_file_get_child
Configuration menu - View commit details
-
Copy full SHA for 1a86517 - Browse repository at this point
Copy the full SHA 1a86517View commit details -
Configuration menu - View commit details
-
Copy full SHA for dff3669 - Browse repository at this point
Copy the full SHA dff3669View commit details -
Merge pull request #2479 from cgwalters/ci-capsh
ci: Require `libcap2-bin` for `capsh`
Configuration menu - View commit details
-
Copy full SHA for e39280f - Browse repository at this point
Copy the full SHA e39280fView commit details
Commits on Nov 12, 2021
-
lib: Avoid dereferencing NULL error values
Otherwise, this will segfault when callers don't need any exact errors. Signed-off-by: Ryan Gonzalez <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 9c1fe55 - Browse repository at this point
Copy the full SHA 9c1fe55View commit details -
Merge pull request #2481 from refi64/null-error
lib: Avoid dereferencing NULL error values
Configuration menu - View commit details
-
Copy full SHA for edbcf52 - Browse repository at this point
Copy the full SHA edbcf52View commit details
Commits on Nov 18, 2021
-
lib/prune: Avoid unnecessary object serialization
`repo_prune_internal` was deserializing each object and passing the components to `maybe_prune_loose_object`, which promptly reserialized it.
Configuration menu - View commit details
-
Copy full SHA for 47d32d9 - Browse repository at this point
Copy the full SHA 47d32d9View commit details -
Merge pull request #2484 from dbnicholson/prune-serialize
lib/prune: Avoid unnecessary object serialization
Configuration menu - View commit details
-
Copy full SHA for f552e30 - Browse repository at this point
Copy the full SHA f552e30View commit details
Commits on Nov 19, 2021
-
app: Only remount /sysroot if needed
We should only try to remount `/sysroot` if we're actually handling the sysroot repo and the repo isn't writable. We already have public APIs to check each of those, so let's use them. Closes: #2485
Configuration menu - View commit details
-
Copy full SHA for 947acbf - Browse repository at this point
Copy the full SHA 947acbfView commit details
Commits on Nov 22, 2021
-
Merge pull request #2486 from jlebon/pr/remount-ostree
app: Only remount /sysroot if needed
Configuration menu - View commit details
-
Copy full SHA for 48dfff2 - Browse repository at this point
Copy the full SHA 48dfff2View commit details
Commits on Nov 23, 2021
-
Configuration menu - View commit details
-
Copy full SHA for f1155c8 - Browse repository at this point
Copy the full SHA f1155c8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 281d310 - Browse repository at this point
Copy the full SHA 281d310View commit details -
Merge pull request #2489 from ostreedev/release-2021.6
Release 2021.6
Configuration menu - View commit details
-
Copy full SHA for 2dc6ec7 - Browse repository at this point
Copy the full SHA 2dc6ec7View commit details
Commits on Nov 26, 2021
-
lib: misc static analysis fixes
This fixes a few warnings from coverity, none of which really interesting.
Configuration menu - View commit details
-
Copy full SHA for cefc1d7 - Browse repository at this point
Copy the full SHA cefc1d7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 267ca93 - Browse repository at this point
Copy the full SHA 267ca93View commit details
Commits on Dec 3, 2021
-
repo: Change locking for summary regeneration to be shared
This is trying to address: https://pagure.io/fedora-iot/issue/48 Basically we changed rpm-ostree to start doing a shared lock during commit by default, but this broke because pungi is starting a process doing a commit for each architecture, and then trying to regenerate the summary after each one. This patch is deleting a big comment with a rationale for why summary regeneration should be exclusive. Point by point: > This makes sure the commits and deltas don't get > deleted while generating the summary. But prune operations require an exclusive lock, which means that data still can't be deleted when the summary grabs a shared lock. > It also means we can be sure refs > won't be created/updated/deleted during the operation, without having to > add exclusive locks to those operations which would prevent concurrent > commits from working. First: The status quo *has* prevented concurrent commits from working! There is no real locking solution to this problem. What we really need to do here is regenerate the summary after each commit *or* when the caller decides to do it and e.g. include deltas at the same time. It's OK if multiple threads race to regenerate the summary; last-one-wins behavior here is totally fine.
Configuration menu - View commit details
-
Copy full SHA for 2c39bd8 - Browse repository at this point
Copy the full SHA 2c39bd8View commit details
Commits on Dec 6, 2021
-
Merge pull request #2493 from cgwalters/summary-lock-shared
repo: Change locking for summary regeneration to be shared
Configuration menu - View commit details
-
Copy full SHA for a07b8d6 - Browse repository at this point
Copy the full SHA a07b8d6View commit details
Commits on Dec 7, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 581a580 - Browse repository at this point
Copy the full SHA 581a580View commit details -
lib/repo: assert that writable state and error agree
This adds an assertion to check that writable stable and error are in sync. The subsequent logic uses them interchangeably.
Configuration menu - View commit details
-
Copy full SHA for f1e2494 - Browse repository at this point
Copy the full SHA f1e2494View commit details -
lib/repo: do no return an arbitrary mode on failure
This turns the existing check into an assert. Otherwise, the previous code may return an arbitrary repo mode (bare) on failure.
Configuration menu - View commit details
-
Copy full SHA for 4a0ebe5 - Browse repository at this point
Copy the full SHA 4a0ebe5View commit details -
lib/repo: do no return a NULL on failure
This turns an existing check into an assert. The previously returned NULL may result in confusing callers, as none of them is checking for that.
Configuration menu - View commit details
-
Copy full SHA for 58bdfb9 - Browse repository at this point
Copy the full SHA 58bdfb9View commit details -
Merge pull request #2494 from jmarrero/fsf-address
Update FSF license notices to use URL instead of address
Configuration menu - View commit details
-
Copy full SHA for 490f515 - Browse repository at this point
Copy the full SHA 490f515View commit details
Commits on Dec 8, 2021
-
Merge pull request #2496 from lucab/ups/repo-asserts
lib/repo: fix problematic invariant checks
Configuration menu - View commit details
-
Copy full SHA for b56786c - Browse repository at this point
Copy the full SHA b56786cView commit details
Commits on Dec 10, 2021
-
tests: assert mandatory values are present
This adds a couple of string assertions to make sure that the test run is sane.
Configuration menu - View commit details
-
Copy full SHA for f44eaf7 - Browse repository at this point
Copy the full SHA f44eaf7View commit details -
Merge pull request #2498 from lucab/ups/test-assert-strings
tests: assert mandatory values are present
Configuration menu - View commit details
-
Copy full SHA for 365559e - Browse repository at this point
Copy the full SHA 365559eView commit details
Commits on Dec 13, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 3f5d226 - Browse repository at this point
Copy the full SHA 3f5d226View commit details -
Update upstream source from tag 'upstream/2021.6'
Update to upstream version '2021.6' with Debian dir 1fe0a45676f3a27ea217d239d7305b44001f2527
Configuration menu - View commit details
-
Copy full SHA for f5a8ff4 - Browse repository at this point
Copy the full SHA f5a8ff4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 61ba306 - Browse repository at this point
Copy the full SHA 61ba306View commit details -
Configuration menu - View commit details
-
Copy full SHA for afc491e - Browse repository at this point
Copy the full SHA afc491eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6138568 - Browse repository at this point
Copy the full SHA 6138568View commit details
Commits on Dec 20, 2021
-
main: add support for CLI extensions via external binaries
This adds some logic to detect and dispatch unknown subcommands to extensions available in `$PATH`. Additional commands can be implemented by adding relevant `ostree-$verb` binaries to the system. As an example, if a `/usr/bin/ostree-extcommand` extension is provided, the execution of `ostree extcommand --help` will be dispatched to that as `ostree-extcommand extcommand --help`.
Configuration menu - View commit details
-
Copy full SHA for 513b3c0 - Browse repository at this point
Copy the full SHA 513b3c0View commit details -
Merge pull request #2500 from lucab/ups/cli-extensions
main: add support for CLI extensions via external binaries
Configuration menu - View commit details
-
Copy full SHA for 7c67199 - Browse repository at this point
Copy the full SHA 7c67199View commit details
Commits on Dec 21, 2021
-
tests/cli-extensions: tweak test logic
This updates the test logic for CLI extensions, actually checking for functional output from the subcommand. It also cleans up some environmental leftover.
Configuration menu - View commit details
-
Copy full SHA for 5dbe37c - Browse repository at this point
Copy the full SHA 5dbe37cView commit details -
Merge pull request #2501 from lucab/ups/test-cli-extensions-tweak
tests/cli-extensions: tweak test logic
Configuration menu - View commit details
-
Copy full SHA for 998863e - Browse repository at this point
Copy the full SHA 998863eView commit details -
soup-uri: Fix clang-analyzer warning by dropping dead code
Fixes `Argument with 'nonnull' attribute passed null` by making the code not exist at all anymore. In upstream libsoup this code is gone too; it uses `GUri` from glib which we probably could now too, but one thing at a time.
Configuration menu - View commit details
-
Copy full SHA for 27c14f2 - Browse repository at this point
Copy the full SHA 27c14f2View commit details -
tests: Fix clang-analyzer not seeing through
g_error()
Basically due to the glib structured logging rework we lost the `noreturn` attribute on `g_error()`. This is fixed in glib as of https://gitlab.gnome.org/GNOME/glib/-/commit/f97ff20adf4eb7b952dd83e2c13046fe9e282f50 But we might as well just throw an error here.
Configuration menu - View commit details
-
Copy full SHA for d2f5a04 - Browse repository at this point
Copy the full SHA d2f5a04View commit details -
Merge pull request #2502 from cgwalters/analyzer
two minor clang-analyzer fixes
Configuration menu - View commit details
-
Copy full SHA for b1ddc6c - Browse repository at this point
Copy the full SHA b1ddc6cView commit details
Commits on Jan 3, 2022
-
lib: use ostree-content-writer header
This installs and exposes the content of `ostree-content-writer.h`, so that library consumers can properly reference symbols defined in that header.
Configuration menu - View commit details
-
Copy full SHA for cf81428 - Browse repository at this point
Copy the full SHA cf81428View commit details -
Merge pull request #2503 from lucab/ups/libostree-content-writer-header
lib: use ostree-content-writer header
Configuration menu - View commit details
-
Copy full SHA for a27ccc9 - Browse repository at this point
Copy the full SHA a27ccc9View commit details -
bsdiff: bump submodule, pick up fix for CVE-2014-9862
This updates the bsdiff submodule to latest upstream revision, in order to pick up additional bound checks for CVE-2014-9862. Update submodule: bsdiff Ref: * https://www.x41-dsec.de/lab/advisories/x41-2020-006-bspatch/
Configuration menu - View commit details
-
Copy full SHA for 97399c1 - Browse repository at this point
Copy the full SHA 97399c1View commit details -
lib/static-delta: throw a proper error on bspatch failure
This makes sure that a populated GError is returned when bsdiff patching fails. The human-friendly label also helps in debugging.
Configuration menu - View commit details
-
Copy full SHA for eae35b7 - Browse repository at this point
Copy the full SHA eae35b7View commit details -
Merge pull request #2504 from lucab/ups/bsdiff-CVE-2014-9862
bsdiff: bump submodule, pick up fix for CVE-2014-9862
Configuration menu - View commit details
-
Copy full SHA for 371c2f1 - Browse repository at this point
Copy the full SHA 371c2f1View commit details -
Merge pull request #2505 from lucab/ups/bsdiff-error-throw
lib/static-delta: throw a proper error on bspatch failure
Configuration menu - View commit details
-
Copy full SHA for 4d47733 - Browse repository at this point
Copy the full SHA 4d47733View commit details
Commits on Jan 4, 2022
-
rofiles-fuse: Build using FUSE 3 if possible, falling back to FUSE 2
This adds build-time configuration logic to automatically detect and switch between libfuse 2.x and 3.x. Signed-off-by: Simon McVittie <[email protected]> Co-authored-by: Luca BRUNO <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 43859b5 - Browse repository at this point
Copy the full SHA 43859b5View commit details -
Merge pull request #2376 from smcv/fuse3
rofiles-fuse: Build using FUSE 3 if possible, falling back to FUSE 2
Configuration menu - View commit details
-
Copy full SHA for a3555f4 - Browse repository at this point
Copy the full SHA a3555f4View commit details -
This adds a configuration file for dependabot, taking care of automatic updates for all git submodules.
Configuration menu - View commit details
-
Copy full SHA for 2bfdcea - Browse repository at this point
Copy the full SHA 2bfdceaView commit details -
Merge pull request #2506 from lucab/ups/dependabot-config
github: add dependabot config
Configuration menu - View commit details
-
Copy full SHA for 8e3323f - Browse repository at this point
Copy the full SHA 8e3323fView commit details
Commits on Jan 5, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 6c903ab - Browse repository at this point
Copy the full SHA 6c903abView commit details
Commits on Jan 7, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 13edc15 - Browse repository at this point
Copy the full SHA 13edc15View commit details -
Update upstream source from tag 'upstream/2022.1'
Update to upstream version '2022.1' with Debian dir 8a98c57b6bb7149bd55803c783f08a2e917525b8
Configuration menu - View commit details
-
Copy full SHA for 286a307 - Browse repository at this point
Copy the full SHA 286a307View commit details -
Configuration menu - View commit details
-
Copy full SHA for 97e4b7a - Browse repository at this point
Copy the full SHA 97e4b7aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 285a482 - Browse repository at this point
Copy the full SHA 285a482View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3c7db4e - Browse repository at this point
Copy the full SHA 3c7db4eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3172dd9 - Browse repository at this point
Copy the full SHA 3172dd9View commit details -
Configuration menu - View commit details
-
Copy full SHA for c128e91 - Browse repository at this point
Copy the full SHA c128e91View commit details
Commits on Jan 10, 2022
-
ostree Breaks flatpak-builder (<< 1.2.1-2~)
Previous versions relied on being able to use FUSE 2 options that are no longer supported by FUSE 3, so prepare a lockstep transition.
Configuration menu - View commit details
-
Copy full SHA for 336f3b8 - Browse repository at this point
Copy the full SHA 336f3b8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 313909d - Browse repository at this point
Copy the full SHA 313909dView commit details
Commits on Jan 24, 2022
-
Configuration menu - View commit details
-
Copy full SHA for acd23f9 - Browse repository at this point
Copy the full SHA acd23f9View commit details -
Use debhelper 11 features instead of dh-exec
Since compat level 11, man pages installed by the upstream build system can be listed in d/*.manpages and will automatically be excluded under the nodoc build-profile.
Configuration menu - View commit details
-
Copy full SHA for e920c28 - Browse repository at this point
Copy the full SHA e920c28View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5501200 - Browse repository at this point
Copy the full SHA 5501200View commit details
Commits on Feb 3, 2022
-
Remove grub2 files from ostree-boot package
Endless doesn't use the full GRUB integration (etc/grub.d/15_ostree), but instead we only use the Boot Loader Spec (BLS) configuration from GRUB to show new ostree entries. Rebase 2019.3 (T27607): replaced 4705bb8 "Restore ostree-boot files to main ostree package" Debian doesn't install the ostree-boot package since they don't have a way to confirm it works, but we install those pieces as part of the main ostree package. The only exception is the full GRUB integration (etc/grub.d/15_ostree), where we only use the Boot Loader Spec (BLS) configuration from GRUB to show new ostree entries. https://phabricator.endlessm.com/T17204 Rebase 2018.6 (T23138): Move the new systemd service lib/systemd/system/ostree-finalize-staged.service from ostree-boot to ostree Rebase 2019.1 (T25195): Move ostree-finalize-staged.path from ostree-boot to ostree Rebase 2019.3 (T27607): Re-integrate non-grub parts with ostree-boot package which is now built in debian.
Configuration menu - View commit details
-
Copy full SHA for 3744d4c - Browse repository at this point
Copy the full SHA 3744d4cView commit details
Commits on Feb 4, 2022
-
This reverts commit 285a482. Our flatpak-builder doesn't support FUSE 3, so we'll continue to build `rofiles-fuse` with FUSE 2. https://phabricator.endlessm.com/T32964
Configuration menu - View commit details
-
Copy full SHA for e3b8d73 - Browse repository at this point
Copy the full SHA e3b8d73View commit details -
Revert "ostree Breaks flatpak-builder (<< 1.2.1-2~)"
This reverts commit 336f3b8. Our flatpak-builder is older than this and we've reverted the change to use FUSE 3 to maintain compatibility. https://phabricator.endlessm.com/T32964
Configuration menu - View commit details
-
Copy full SHA for f0bbc8b - Browse repository at this point
Copy the full SHA f0bbc8bView commit details -
debian: Document Endless packaging changes
Our packaging diverges from debian's because our package provides most of the booting bits that debian put in its placeholder ostree-boot package. See debian/README.Endless for details. Signed-off-by: Philip Withnall <[email protected]> https://phabricator.endlessm.com/T18836 Rebase 2019.1 (T25195): Changed usr/lib/libostree/grub2-15_ostree to usr/libexec/libostree/grub2-15_ostree Rebase 2019.3 (T27607): squashed with 3d90106 "Update README.Endless with pointer to debian's git" https://phabricator.endlessm.com/T22022 Rebase 2019.3 (T27607): Updated documentation Rebase 2020.8 (T31593): squashed with b1aff69 "d/README.Endless: Update downstream changes documentation" Rebase 2022.1 (T32964): squashed with 1d7aaa6 "d/README.Endless: Remove trivial-httpd delta". Updated documentation to remove `gjs` delta and mention FUSE 2 vs FUSE 3 delta.
Configuration menu - View commit details
-
Copy full SHA for 4cdf13d - Browse repository at this point
Copy the full SHA 4cdf13dView commit details -
This patch has been applied to the source branch. https://phabricator.endlessm.com/T32964
Configuration menu - View commit details
-
Copy full SHA for 9a0080d - Browse repository at this point
Copy the full SHA 9a0080dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9ce2751 - Browse repository at this point
Copy the full SHA 9ce2751View commit details